Add experimental WSLC container orchestrator - #257
Draft
Karol Zadora-Przylecki (karolz-ms) wants to merge 1 commit into
Draft
Karol Zadora-Przylecki (karolz-ms) wants to merge 1 commit into
Karol Zadora-Przylecki (karolz-ms) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a native WSLC CLI-backed container orchestrator in
internal/wslc, alongside Docker and Podman, and integrate it with the real-runtime conformance infrastructure from #254.--container-runtime wslcand deterministic automatic preference: healthy Docker, then Podman, then WSLC.ContainerHost()as a string contract; an emptyhostNameexplicitly means a default container-to-host address is unsupported, not that the runtime is unhealthy.Implementation details
Why this is a draft
WSLC CLI 2.9.11.0 does not expose native container/network events. Watch methods return explicit unsupported errors; there is no polling substitute or successful no-op subscription. This PR should remain a draft until native CLI events can be wired up and the event-dependent gates removed.
The three intentionally gated WSLC real-runtime cases are:
TestWatchContainersMethod/wslcTestWatchNetworksMethod/wslcTestTunnelProxyWithRealOrchestrator/wslcNon-event conformance, direct PTY attachment, controller-terminal integration, image layers, and V2 network cleanup remain enabled and pass.
CONTRIBUTING.mddocuments the remaining CLI limitations and adaptations, including build platform selection, non-default restart policy, health-check start interval, IPv6 network creation, raw capability flags, and unsupported default host addressing. Missing CLI exposure does not imply the underlying WSL runtime lacks those capabilities.Validation
Passed on Windows with Docker 29.7.2 and WSLC 2.9.11.0:
make test-prereqsmake compilemake lint— 0 issuesmake testwith the true-runtime opt-in disabledmake testwithDCP_TEST_ENABLE_TRUE_CONTAINER_ORCHESTRATOR=trueandTEST_CONTEXT_TIMEOUT=180— 85 passing packagesPodman was not installed on the validation machine, so its unit tests ran but real Podman execution was unavailable. The five focused review findings were addressed and re-reviewed before the final full-suite runs.