fix(build): pin all dependencies for OSSF Scorecard#402
Merged
WilliamBerryiii merged 6 commits intomainfrom Apr 21, 2026
Merged
fix(build): pin all dependencies for OSSF Scorecard#402WilliamBerryiii merged 6 commits intomainfrom
WilliamBerryiii merged 6 commits intomainfrom
Conversation
- pin GitHub Actions to commit SHAs; migrate workflows to npm ci - regenerate npm and pip lockfiles with hashes - pin Dockerfile base images by sha256 and tool versions - enable NuGet lockfiles with --locked-mode restore 🔒 - Generated by Copilot
This was referenced Apr 19, 2026
katriendg
approved these changes
Apr 20, 2026
Collaborator
katriendg
left a comment
There was a problem hiding this comment.
Left one comment with the reviewer, other were minor and not worth posting.
Resolve conflicts: - package.json: drop docsify-cli (removed in main with docsify->docusaurus migration) - .github/workflows/docs-automation.yml: keep main's version (docsify build job removed) - requirements.in: bump python-hcl2 to 8.1.2 and checkov to 3.2.521 from main - requirements.txt and package-lock.json: regenerate with pinned hashes Address review comment RI-1 (security-staleness-check.yml): - Add actions/setup-python step (PEP 668 externally-managed-environment fix) - Add Get-Command checkov guard so a missing binary fails loudly
# Conflicts: # src/100-edge/100-cncf-cluster/scripts/deploy-script-secrets.sh # src/100-edge/100-cncf-cluster/scripts/k3s-device-setup.sh
…security-comprehensive workflow 🔒 - Generated by Copilot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(build): pin all dependencies for OSSF Scorecard
Description
Remediates the OSSF Scorecard Pinned-Dependencies finding (47 warnings + 1 shell parse error) across the repository. Single commit
7f09fa50updates 75 files (+12,455 / -331) to pin GitHub Actions by commit SHA, regenerate hashed Python lockfiles, pin Docker base images bysha256digest with explicit tool versions, switch npm installs tonpm ciwith refreshedpackage-lock.json, and lock NuGet restores viapackages.lock.json. A shell parse error inscripts/k3s-device-setup.shis also fixed.Related Issue
Closes #403
Type of Change
Implementation Details
pip-compile --generate-hashesacross 26 sites; added.github/requirements/for workflow-scoped Python tooling and renamed root requirements torequirements.base.in/requirements.base.txt.sha256digest and pinned tool versions in 16downloadThenRuninstall sites; deviation PD-03 removes redundantrustupfrom 502 broker/subscriber images (Pattern B); deviation PD-04 keepscolconbuilder-only.npm ciacross 4 sites;package-lock.jsonregenerated (+2,161 lines). Risk:secretlintbumped 9.3.4 → 12.0.0 (major).packages.lock.jsonfor InferencePipeline and Tests projects (+369 / +550 lines).scripts/k3s-device-setup.sh.Testing Performed
pip-compiledry-run,npm ci,dotnet restore --locked-modeValidation Steps
npm run mdlint-fix pip install --require-hashes -r .github/requirements/requirements.txt dotnet restore --locked-mode # Re-run OSSF Scorecard locally or via workflow to confirm Pinned-Dependencies score delta.Checklist
terraform fmtrun on all modified filesterraform validatepassesaz bicep formatrun on all modified filesaz bicep buildpassesSecurity Review
Additional Notes
Review log:
.copilot-tracking/reviews/2026-04-17/ossf-pinned-dependencies-review.md— Status ✅ Complete; 0 Critical / 0 Major / 3 Minor / 4 Info. Reviewer note: "No rework required to ship; recommend reconciling docs and running OSSF re-scan before opening any PR."Minor follow-ups (not blocking):
[ ]) and changes-log file count (says 67; actual 75).secretlintv12 (major bump from 9.3.4).actionlint, NuGet Central Package Management, documentUpdate-DockerSHAPinning.ps1.Deviations from plan: PD-01 base branch is
main(notdev); PD-02--generate-hashesfor pip-compile; PD-03 Pattern B removal of rustup in 502 broker/subscriber; PD-04 colcon builder-only; PD-05 loose.inconstraints with pinning enforced in.txt.Screenshots
n/a