Skip to content

fix(build): resolve CI gates blocking pages-deploy-main#422

Draft
WilliamBerryiii wants to merge 2 commits intomainfrom
fix/main-ci-gates-pages-deploy
Draft

fix(build): resolve CI gates blocking pages-deploy-main#422
WilliamBerryiii wants to merge 2 commits intomainfrom
fix/main-ci-gates-pages-deploy

Conversation

@WilliamBerryiii
Copy link
Copy Markdown
Member

Summary

Restores https://microsoft.github.io/edge-ai/ by fixing the three failing required gates that block deploy-pages-main in .github/workflows/main.yml.

Closes #421

Root Causes & Fixes

Gate (job) Root cause Fix
Code Quality Duplicate keys in eslint.config.js globals object caused parse failure Deduped globals (file now ends at L146)
Security Monitoring ConvertFrom-Json returned PSCustomObject, but downstream code indexed it as a hashtable in scripts/security/New-SecurityDashboard.ps1 Added -AsHashtable to the ConvertFrom-Json call (L783)
Shell Lint 79 .sh files were not formatted to shfmt defaults; shell-lint.yml runs shfmt --diff Ran shfmt --write across all 79 files; 0 diffs remain

Verification

  • eslint.config.js: parses cleanly; no duplicate globals keys.
  • New-SecurityDashboard.ps1: hashtable indexing now matches input shape.
  • shfmt --diff against all 79 modified .sh files: empty output.

Risk

  • Shell script changes are formatting-only (whitespace, indentation, line continuations). No behavioral changes.
  • eslint.config.js change removes only redundant duplicate entries.
  • PowerShell change is a single switch addition (-AsHashtable) consistent with how the parsed object is consumed.

Follow-up

After merge, watch the next main run to confirm deploy-pages-main succeeds and the Pages site returns to the workflow-built Docusaurus output.

🔧 - Generated by Copilot

- dedupe duplicate globals in eslint.config.js (Code Quality gate)
- use -AsHashtable in New-SecurityDashboard.ps1 (Security Monitoring gate)
- apply shfmt --write across 79 shell scripts (Shell Lint gate)

Refs #421

🔧 - Generated by Copilot
@WilliamBerryiii WilliamBerryiii requested a review from a team as a code owner April 20, 2026 20:37
@WilliamBerryiii
Copy link
Copy Markdown
Member Author

DO NOT MERGE ... I Think this PR is mostly a no-op after the previous PRs merged ... still need to check it out.

@WilliamBerryiii WilliamBerryiii marked this pull request as draft April 21, 2026 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

main CI gates blocking GitHub Pages deploy (Docusaurus site stale)

1 participant