fix(build): resolve CI gates blocking pages-deploy-main#422
Draft
WilliamBerryiii wants to merge 2 commits intomainfrom
Draft
fix(build): resolve CI gates blocking pages-deploy-main#422WilliamBerryiii wants to merge 2 commits intomainfrom
WilliamBerryiii wants to merge 2 commits intomainfrom
Conversation
- dedupe duplicate globals in eslint.config.js (Code Quality gate) - use -AsHashtable in New-SecurityDashboard.ps1 (Security Monitoring gate) - apply shfmt --write across 79 shell scripts (Shell Lint gate) Refs #421 🔧 - Generated by Copilot
Member
Author
|
DO NOT MERGE ... I Think this PR is mostly a no-op after the previous PRs merged ... still need to check it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores https://microsoft.github.io/edge-ai/ by fixing the three failing required gates that block
deploy-pages-mainin.github/workflows/main.yml.Closes #421
Root Causes & Fixes
eslint.config.jsglobalsobject caused parse failureConvertFrom-JsonreturnedPSCustomObject, but downstream code indexed it as a hashtable inscripts/security/New-SecurityDashboard.ps1-AsHashtableto theConvertFrom-Jsoncall (L783).shfiles were not formatted toshfmtdefaults;shell-lint.ymlrunsshfmt --diffshfmt --writeacross all 79 files; 0 diffs remainVerification
eslint.config.js: parses cleanly; no duplicateglobalskeys.New-SecurityDashboard.ps1: hashtable indexing now matches input shape.shfmt --diffagainst all 79 modified.shfiles: empty output.Risk
eslint.config.jschange removes only redundant duplicate entries.-AsHashtable) consistent with how the parsed object is consumed.Follow-up
After merge, watch the next
mainrun to confirmdeploy-pages-mainsucceeds and the Pages site returns to the workflow-built Docusaurus output.🔧 - Generated by Copilot