Fix a few issues with some rules we noticed when migrating to flat config#88
Fix a few issues with some rules we noticed when migrating to flat config#88christiango wants to merge 6 commits into
Conversation
|
Hey @christiango since you are working at Microsoft too I see, could you ping some of the maintaners internally to check this PR and also the eslint v10 support? This package has ove 500k weekly downloads and blocks us from updating to eslint v10 |
I've sent an email internally to some of the historical contributors to see what the status is |
Verify exact Element types originate from lib.dom.d.ts, add regression coverage for local and DOM Element types, and exercise Window unions with strict null checking. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c5c981a3-aec0-4094-8d03-3a49e13df9f2
Reject custom types named Window while preserving DOM Window union handling, and share declaration-origin checks between the Window and Element rules. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c5c981a3-aec0-4094-8d03-3a49e13df9f2
|
Hey @christiango I see you got an approval so you can merge soon 😀 However did you got a response regarding eslint v10 support in this plugin? There is even an open PR that would need a review and merge if its ok. (And then new release..) |
|
Forgot to add that this is getting increasingly urgent as ESLint 9.x goes EOL on August 6th, |
I don't have write permissions so I'm not able to merge, plus there seems to be an issue with one of the required checks. I did reach out to the team and they did mention they were looking in to it and that lead to a review on this PR. I'm not sure what the plans are for overall eslint 10 support. Do you know @plade? |
3 participants
I work on an internal repo at Microsoft that uses these rules. We noticed that when upgrading to eslint flat config that some eslint errors were no longer firing. After some debugging we found that the following issues issues: