feat(fast-element): warn on duplicate render registrations#7553
Draft
janechu wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
7924713 to
170d29e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Adds a debug warning when
RenderInstruction.register()replaces an existing instruction for the same model type and instruction name. The PR adds focused Playwright coverage for duplicate and distinct-name render registrations, documents replacement behavior inpackages/fast-element/DESIGN.md, and includes a beachball change file.📑 Test Plan
npm run build:tsc -w @microsoft/fast-elementFAST_TEST_SERVER_URL=http://localhost:5273/ npx playwright test src/templating/render-registration.pw.spec.ts --project=chromiumnpx biome check packages/fast-element/src/debug.ts packages/fast-element/src/interfaces.ts packages/fast-element/src/templating/render.ts packages/fast-element/src/templating/render-registration.pw.spec.ts packages/fast-element/DESIGN.md change/@microsoft-fast-element-4dbc9ebd-2055-4ad1-af2a-5f3dacb6decc.jsonnpm run checkchange✅ Checklist
General
$ npm run change