Skip to content

feat(fast-element): warn on duplicate render registrations#7553

Draft
janechu wants to merge 1 commit into
releases/fast-element-v3from
users/janechu/render-registration-warning
Draft

feat(fast-element): warn on duplicate render registrations#7553
janechu wants to merge 1 commit into
releases/fast-element-v3from
users/janechu/render-registration-warning

Conversation

@janechu
Copy link
Copy Markdown
Collaborator

@janechu janechu commented May 29, 2026

Pull Request

📖 Description

Adds a debug warning when RenderInstruction.register() replaces an existing instruction for the same model type and instruction name. The PR adds focused Playwright coverage for duplicate and distinct-name render registrations, documents replacement behavior in packages/fast-element/DESIGN.md, and includes a beachball change file.

📑 Test Plan

  • npm run build:tsc -w @microsoft/fast-element
  • FAST_TEST_SERVER_URL=http://localhost:5273/ npx playwright test src/templating/render-registration.pw.spec.ts --project=chromium
  • npx biome check packages/fast-element/src/debug.ts packages/fast-element/src/interfaces.ts packages/fast-element/src/templating/render.ts packages/fast-element/src/templating/render-registration.pw.spec.ts packages/fast-element/DESIGN.md change/@microsoft-fast-element-4dbc9ebd-2055-4ad1-af2a-5f3dacb6decc.json
  • npm run checkchange

✅ Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@janechu janechu force-pushed the users/janechu/render-registration-warning branch from 7924713 to 170d29e Compare May 29, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant