Add msgo/module telemetry counters#2283
Draft
gdams wants to merge 2 commits into
Draft
Conversation
157fe41 to
b3ed91d
Compare
b3ed91d to
ee50eec
Compare
qmuntal
requested changes
May 18, 2026
qmuntal
approved these changes
May 18, 2026
dagood
requested changes
May 18, 2026
Member
There was a problem hiding this comment.
Discussion in https://github.com/microsoft/go-lab/issues/382
Member
|
@gdams - needs a rebase |
Member
Author
|
cherry-picking the CI counter out into #2314 |
871c54f to
ba2d84a
Compare
ba2d84a to
af45c99
Compare
qmuntal
requested changes
May 27, 2026
qmuntal
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a SHA-256 hash of the Go module path as a custom property on the
go/invocationstelemetry event, and vendor the updatedgo-infra/telemetrydependency (which includes support for counter properties and property filtering).fixes: https://github.com/microsoft/go-lab/issues/382
New telemetry
msgo/module/hashproperty ongo/invocationsWhen
go/invocationsis recorded, the nearestgo.modfile is located and the module path is hashed using SHA-256. The resulting hash is sent as a custom property (msgo/module/hash) on thego/invocationsevent. This is a one-way hash — the original module path cannot be recovered from it.The hash is only sent when a
go.modfile is found. If nogo.modis present,go/invocationsis sent without the property.Dependency changes
github.com/microsoft/go-infra/telemetryto include support forNewWithProperties(),PropertyFilter, and counter property configuration inconfig.json.Patch changes
NewWithPropertiescall inInc().Documentation
eng/doc/Telemetry.mdto document the newmsgo/module/hashproperty and clarify that module names are not collected (only hashes).