Use FIPSCapable#2315
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores a separate FIPSCapable check in the OpenSSL backend so the backend can distinguish “FIPS mode is enabled” from “the default provider is FIPS-capable”, addressing environments where fips=yes isn’t set but a FIPS-capable provider is in use.
Changes:
- Switch the OpenSSL backend’s FIPS availability check to use
osslsetup.FIPSCapable(). - Vendor a newer
github.com/microsoft/go-crypto-opensslrevision that reintroduces/extendsFIPSCapableand related OpenSSL-version handling.
Patches are happy!
Show a summary per file
| File | Description |
|---|---|
| patches/0003-Implement-crypto-internal-backend.patch | Updates the backend initialization logic to use FIPSCapable for FIPS-availability checks and adjusts related commentary. |
| patches/0001-Vendor-external-dependencies.patch | Bumps the vendored go-crypto-openssl module and adds/updates FIPS detection helpers (including FIPSCapable). |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 3
karianna
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A previous PR removed
FIPSCapable, as the OpenSL backend merged it withFIPS(). Both functions are useful independently, so the OpenSSL backend reverted the change.