fix: preserve entities without community assignments in level filter (fixes #2348)#2368
Open
hanhan761 wants to merge 1 commit into
Open
fix: preserve entities without community assignments in level filter (fixes #2348)#2368hanhan761 wants to merge 1 commit into
hanhan761 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_filter_under_community_level\ uses \df[df.level <= community_level]\ which evaluates to \False\ for NaN values. Entities not assigned to any community by Leiden detection get \level = NaN\ after a left join and are silently dropped, causing the query engine to operate on a drastically reduced entity set with no warning.
Changes
\graphrag/query/indexer_adapters.py: Added | df.level.isna()\ to the filter condition so that entities without community assignments are preserved. Since "not in any community" is not the same as "in a community above the requested level," retaining them is the semantically correct behavior.
Related
Fixes #2348