fix: preserve entities without community assignment in _filter_under_community_level (#2348)#2371
Open
hanhan761 wants to merge 1 commit into
Open
fix: preserve entities without community assignment in _filter_under_community_level (#2348)#2371hanhan761 wants to merge 1 commit into
hanhan761 wants to merge 1 commit into
Conversation
…community_level (microsoft#2348) _filter_under_community_level uses df.level <= community_level which evaluates to False for NaN values, silently dropping all entities that were not assigned to any community during Leiden detection. Fix by adding df.level.isna() to the filter condition. Also add None handling for community_level parameter so callers can bypass the filter entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #2348:
_filter_under_community_level()usesdf.level <= community_levelwhich evaluates toFalsefor NaN values, silently dropping all entities that were not assigned to any community during Leiden community detection. This causes CLI query commands to operate on a drastically reduced entity set with no warning.Changes
In
graphrag/query/indexer_adapters.py:| df.level.isna()to the filter condition so entities without community assignment are preservedNonehandling forcommunity_levelparameter so callers can bypass the filterIssue
Fixes #2348