fix: _filter_under_community_level silently drops entities without community assignments#2375
Open
hanhan761 wants to merge 1 commit into
Open
fix: _filter_under_community_level silently drops entities without community assignments#2375hanhan761 wants to merge 1 commit into
hanhan761 wants to merge 1 commit into
Conversation
…mmunity assignments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2348
Problem
_filter_under_community_levelinindexer_adapters.pyfilters entities usingdf[df.level <= community_level]. Entities without community assignments haveNaNin thelevelcolumn after the left join with community membership data. SinceNaN <= xevaluates toFalsein pandas/NumPy, all unassigned entities are silently dropped with no warning.This causes CLI query commands (
graphrag query --method local/global/drift) to operate on a drastically reduced entity set. Small, sparse, or domain-specific datasets are especially vulnerable since isolated nodes are routinely excluded by Leiden community detection.Fix
Changed the filter to also preserve rows where
levelis NaN:This is semantically correct: "not in any community" is not the same as "in a community above the requested level." Entities without community assignments should pass through the filter.
Test
Added
tests/unit/query/test_indexer_adapters.pywith 5 test cases covering: