fix: use safe_substitute in config loader to avoid crash on $ in values (fixes #2349)#2380
Open
hanhan761 wants to merge 1 commit into
Open
fix: use safe_substitute in config loader to avoid crash on $ in values (fixes #2349)#2380hanhan761 wants to merge 1 commit into
hanhan761 wants to merge 1 commit into
Conversation
…rsing Template(text).substitute(os.environ) crashes on bare $ characters in config values (e.g. regex file_pattern ending with $). Changed to safe_substitute() which leaves unrecognized placeholders as literal text. Fixes microsoft#2349
hanhan761
force-pushed
the
fix-2349-template-safe-substitute
branch
from
1b3ffb3 to
d17153e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces string.Template.substitute() with safe_substitute() in the config loader so that bare $ characters (e.g. in regex file_pattern values) don't crash the entire pipeline.
Issue
Closes #2349
Root Cause
Template.substitute() raises ValueError on any $ not followed by a valid placeholder identifier. Config values like file_pattern: '.*\\.md$' trigger this.
Fix
Replace substitute() with safe_substitute(), which leaves unrecognized placeholders as literal text.
Verification