fix: remove extraneous True argument from dry-run logger.info call#2385
Open
hanhan761 wants to merge 1 commit into
Open
fix: remove extraneous True argument from dry-run logger.info call#2385hanhan761 wants to merge 1 commit into
hanhan761 wants to merge 1 commit into
Conversation
logger.info('Dry run complete, exiting...', True) passed True as a
format-string argument, but the message string has no %s placeholder.
This caused TypeError: not all arguments converted during string
formatting when running 'graphrag index --dry-run --verbose'.
Fixes microsoft#2254
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running
graphrag index --dry-run --verbose, thelogger.info()call on line 119 ofgraphrag/cli/index.pypasses an extraneous positional argumentTrue:The message string has no
%splaceholder, so Python'sloggingmodule raises:TypeError: not all arguments converted during string formattingThis was the actual error reported in the issue, masked behind the logging error handler.
Fix
Removed the stray
Trueargument so the call is:Related Issues
Fixes #2254
Verification
pytest tests/unit/config/ -v— 10/10 passedpytest tests/unit/chunking/ -v— 11/11 passed