Migrate Tar-RO file system to new backend#1040
Open
jaybosamiya-ms wants to merge 7 commits into
Open
Conversation
Member
Author
|
This PR is easiest to review one commit in it at a time, rather than the whole thing at once. Also, just noting that semver-checks should (expectedly) mention a warning about the |
jaybosamiya-ms
marked this pull request as ready for review
July 17, 2026 22:44
|
🤖 SemverChecks 🤖 Click for details |
Member
|
GPT-5.6 found two potential issues. I will add my review soon.
|
Member
Author
|
Thanks Weidong, for those two:
|
wdcui
reviewed
Jul 18, 2026
| let tar_ro = litebox::fs::resolver::Resolver::new( | ||
| litebox, | ||
| litebox::fs::composer::Composer::builder() | ||
| .mount("/", |allocator| { |
Member
There was a problem hiding this comment.
In the future, should we handle the case where it's not mounted at "/"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches our Tar-RO filesystem to the new core file system design (see #887). Concretely, it adds a
TarRobackend, migrates all old usage oftar_ro::FileSystemto a resolver-backed one to use the newTarRobackend, and then removes the oldtar_ro::FileSystem. It also makes minor tweaks to theBackendinterface to correctly account for read-only file systems. Interestingly, this move to the backend-based handling also gives us a chance to clean up the hardcoded dir stuff inside the tar-ro to instead properly use inode numbering :)