-
Notifications
You must be signed in to change notification settings - Fork 310
ℹ️ Add matteing, gardnerjr as CODEOWNERS for Workbooks #1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds CODEOWNERS entries for the Azure Workbooks tools, assigning @gardnerjr and @matteing as code owners. However, there is already an existing CODEOWNERS entry for the same path that needs to be reconciled.
Key Changes:
- Adds a duplicate CODEOWNERS entry for
/tools/Azure.Mcp.Tools.Workbooks/with two owners - Adds corresponding PRLabel and ServiceLabel comments
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
.github/CODEOWNERS
Outdated
| /tools/Azure.Mcp.Tools.Workbooks/ @gardnerjr @matteing | ||
| # ServiceLabel: %tools-Workbooks | ||
| # ServiceOwners: @gardnerjr @matteing |
Copilot
AI
Nov 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already an existing CODEOWNERS entry for /tools/Azure.Mcp.Tools.Workbooks/ at lines 237-241. This new entry creates a duplicate. You should either:
- Update the existing entry (lines 237-241) to add
@gardnerjras an owner, or - Remove the existing entry and keep this new one
Additionally, note that the existing entry includes @microsoft/azure-mcp team reference, which is consistent with all other Azure MCP tool entries in this file but is missing from this new entry.
| /tools/Azure.Mcp.Tools.Workbooks/ @gardnerjr @matteing | |
| # ServiceLabel: %tools-Workbooks | |
| # ServiceOwners: @gardnerjr @matteing |
.github/CODEOWNERS
Outdated
| /core/Microsoft.Fabric.Mcp.Core/ @microsoft/fabric-mcp | ||
| /servers/Fabric.Mcp.Server/ @microsoft/fabric-mcp | ||
| /tools/Fabric.Mcp.Tools.PublicApi/ @microsoft/fabric-mcp | ||
|
|
Copilot
AI
Nov 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The convention in this file is to have a blank line before each # PRLabel: comment to separate different tool entries. For consistency, add a blank line before line 268.
What does this PR do?
This PR follows the Engineering Hub guidance for onboarding a service to Azure MCP. We've got existing tools in Azure MCP, but have yet to follow the new onboarding procedures in the new repository.
For questions, feel free to message me on Teams.
Pre-merge Checklist