Skip to content

Conversation

@matteing
Copy link
Contributor

@matteing matteing commented Nov 26, 2025

What does this PR do?

This PR follows the Engineering Hub guidance for onboarding a service to Azure MCP. We've got existing tools in Azure MCP, but have yet to follow the new onboarding procedures in the new repository.

For questions, feel free to message me on Teams.

Pre-merge Checklist

Copilot AI review requested due to automatic review settings November 26, 2025 20:25
@matteing matteing requested review from a team as code owners November 26, 2025 20:25
Copilot finished reviewing on behalf of matteing November 26, 2025 20:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds CODEOWNERS entries for the Azure Workbooks tools, assigning @gardnerjr and @matteing as code owners. However, there is already an existing CODEOWNERS entry for the same path that needs to be reconciled.

Key Changes:

  • Adds a duplicate CODEOWNERS entry for /tools/Azure.Mcp.Tools.Workbooks/ with two owners
  • Adds corresponding PRLabel and ServiceLabel comments

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Comment on lines 269 to 271
/tools/Azure.Mcp.Tools.Workbooks/ @gardnerjr @matteing
# ServiceLabel: %tools-Workbooks
# ServiceOwners: @gardnerjr @matteing
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already an existing CODEOWNERS entry for /tools/Azure.Mcp.Tools.Workbooks/ at lines 237-241. This new entry creates a duplicate. You should either:

  1. Update the existing entry (lines 237-241) to add @gardnerjr as an owner, or
  2. Remove the existing entry and keep this new one

Additionally, note that the existing entry includes @microsoft/azure-mcp team reference, which is consistent with all other Azure MCP tool entries in this file but is missing from this new entry.

Suggested change
/tools/Azure.Mcp.Tools.Workbooks/ @gardnerjr @matteing
# ServiceLabel: %tools-Workbooks
# ServiceOwners: @gardnerjr @matteing

Copilot uses AI. Check for mistakes.
/core/Microsoft.Fabric.Mcp.Core/ @microsoft/fabric-mcp
/servers/Fabric.Mcp.Server/ @microsoft/fabric-mcp
/tools/Fabric.Mcp.Tools.PublicApi/ @microsoft/fabric-mcp

Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The convention in this file is to have a blank line before each # PRLabel: comment to separate different tool entries. For consistency, add a blank line before line 268.

Suggested change

Copilot uses AI. Check for mistakes.
@matteing matteing marked this pull request as draft November 26, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants