Skip to content

Conversation

@hallipr
Copy link
Member

@hallipr hallipr commented Dec 4, 2025

What does this PR do?

Moves more types from Azure.Mcp.Core into Microsoft.Mcp.Core

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes using script at eng/scripts/Process-PackageReadMe.ps1. See Package README
    • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • Run .\eng\scripts\Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the MCP codebase by moving core command and area setup types from Azure.Mcp.Core to Microsoft.Mcp.Core, improving the separation of platform-agnostic and Azure-specific functionality.

Key Changes

  • Moved IAreaSetup, CommandGroup, BaseCommand, and related command types from Azure.Mcp.Core.Commands to Microsoft.Mcp.Core.Commands
  • Moved CommandContext, CommandResponse, and CommandInfo from Azure.Mcp.Core.Models.Command to Microsoft.Mcp.Core.Models.Command
  • Extracted Azure-specific telemetry constants (SubscriptionGuid, ResourceHash) into a separate AzureTagName class while moving common telemetry constants to Microsoft.Mcp.Core.Commands

Reviewed changes

Copilot reviewed 300 out of 405 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
core/Microsoft.Mcp.Core/src/Commands/*.cs New location for core command types and interfaces
core/Microsoft.Mcp.Core/src/Models/Command/*.cs New location for command model types
core/Microsoft.Mcp.Core/src/Areas/IAreaSetup.cs Moved area setup interface to Microsoft.Mcp.Core
core/Azure.Mcp.Core/src/Services/Telemetry/*.cs Split telemetry constants between Azure-specific and common
tools/**/src/**/*.cs Updated imports to use Microsoft.Mcp.Core namespaces
servers/**/src/Program.cs Updated imports in server entry points

Copy link
Contributor

Copilot AI commented Dec 4, 2025

@hallipr I've opened a new pull request, #1319, to work on those changes. Once the pull request is ready, I'll request review from you.

@hallipr hallipr force-pushed the users/pahallis/core-migration branch from 7ee723f to ac1ede4 Compare December 5, 2025 00:04
hallipr and others added 3 commits December 5, 2025 16:19
…e migration (#1319)

* Update namespaces to Microsoft.Mcp.Core

* Initial plan

* Fix XML doc namespace for IAreaSetup and update new-command.md using statements

Co-authored-by: hallipr <1291634+hallipr@users.noreply.github.com>

* Fix XML doc namespace and update new-command.md for Microsoft.Mcp.Core migration

Co-authored-by: hallipr <1291634+hallipr@users.noreply.github.com>

---------

Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: hallipr <1291634+hallipr@users.noreply.github.com>
Removed the empty ItemGroup for Exceptions folder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

3 participants