Skip to content

NVX Phase 1: Minimal Signed MicroVM integration - #1528

Merged
Huzaifa Danish (huzaifa-d) merged 21 commits into
mainfrom
user/modanish/nvx-phase1-signed-integration
Oct 27, 2026
Merged

Huzaifa Danish (huzaifa-d) merged 21 commits into
mainfrom
user/modanish/nvx-phase1-signed-integration

Conversation

@huzaifa-d

@huzaifa-d Huzaifa Danish (huzaifa-d) commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

📖 Description

Phase 1 of the NVX integration stack.
Replace the active Nanvix integration with the minimum Windows x64 NVX captured create-and-run path, behind the existing microvm feature.

Phase 1 Image limitation: The workload image is fixed to mcr.microsoft.com/azurelinux/base/core:3.0. Requests cannot select another image. This is temporary and handled in phase two.

🔗 References

Part of #1586.

✅ Checklist

📋 Issue Type

  • Bug fix
  • Feature
  • Task

GitHub Actions runs the PR validation build automatically. The ADO pipeline
(MXC-PR-Build) is the Azure version of the PR pipeline, kept in parity with the GitHub
Actions build; it runs on merge to main, and Microsoft reviewers with write access can trigger it
on a PR with /azp run. See pull request builds.

If the dependency-feed-check check fails on a new dependency, the crate must be added to
the feed before the PR can pass. See pull request builds
for the steps.

Microsoft Reviewers: Open in CodeFlow

Add the minimal signed create-and-run NVX0430 bundle.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: aee99423-dfee-4d61-86e9-421b944c4cc0
Copilot AI balanced review requested due to automatic review settings October 19, 2026 17:58
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

This comment was marked as resolved.

Preserve executor output bytes and propagate test failures. Correct timeout assertions and simplify review wording and documentation.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
huzaifa-msft and others added 2 commits October 19, 2026 12:52
Link the root README to the SDK integration notes and document host prerequisites and policy restrictions there.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Restore the Nanvix guide unchanged from the PR base and keep the README and CI notes focused on the current integration.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 19, 2026 21:59

This comment was marked as resolved.

@huzaifa-d
Huzaifa Danish (huzaifa-d) marked this pull request as ready for review October 20, 2026 18:07
@huzaifa-d
Huzaifa Danish (huzaifa-d) requested a review from a team as a code owner October 20, 2026 18:07
@huzaifa-d Huzaifa Danish (huzaifa-d) changed the title NVX phase 1: minimal signed MicroVM integration NVX phase 1: Minimal Signed MicroVM integration Oct 20, 2026
@huzaifa-d Huzaifa Danish (huzaifa-d) changed the title NVX phase 1: Minimal Signed MicroVM integration NVX Phase 1: Minimal Signed MicroVM integration Oct 20, 2026
huzaifa-msft and others added 5 commits October 21, 2026 16:08
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Remove unpublished Rust dependencies, retain pinned bundle verification, and validate packaging and explicit MicroVM CI execution.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 22, 2026 01:49

This comment was marked as resolved.

Enforce the combined 64 MiB output budget with cancellation and cleanup, validate process limits before bundle discovery, and validate the mapped native request before provisioning. Cover boundaries and cleanup through runtime and signed-bundle scenarios.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 22, 2026 21:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Native loading and VM teardown require human review, particularly while functional CI fails during startup and diagnostic preservation remains unresolved.

1 open issue
3 resolved since last review

Review effort: Balanced

Comment thread src/mxc-sdk/src/backends/nvx/runner.rs
Copilot AI balanced review requested due to automatic review settings October 26, 2026 23:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The native runtime replacement and cancellation guarantees need final human review backed by Windows x64 Hypervisor Platform execution and teardown results.

1 open issue

Review effort: Balanced

Restore the exact adapters and normalized models to main. Ignore legacy fallback settings consistently, with equivalent-policy and real executor/facade coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 27, 2026 00:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Native runtime integration, console interruption, and VM cleanup require final human review backed by successful validation on a Windows x64 host with Windows Hypervisor Platform enabled.

1 open issue

Review effort: Balanced

Preserve the complete pinned runtime in release ZIPs and VPack without re-signing. Exclude the unsupported MicroVM payload from npm with a scoped package rule and cover copy, ZIP hashes, missing inputs, and actual npm tarball contents.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 27, 2026 00:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Native VM execution, cancellation cleanup, and signed-bundle deployment require verified Windows x64 host results and final human review.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Keep the prebuilt suite in backend validation artifacts without publishing it as an SDK binary. Reproduce the failing CI tarball contents in the real npm pack regression and preserve the strict package allowlist.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 27, 2026 16:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Verified merge-build compilation failure blocks approval; native VM lifecycle and packaging changes also warrant human review with Windows validation results.

1 open issue

Review effort: Balanced

Comment thread src/mxc-sdk/src/core/mxc_engine/mod.rs Outdated
Pass stdin=false from captured JSON execution, matching the run-to-completion contract while keeping explicit writable-stdin spawn operations unchanged.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 27, 2026 16:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Native VM cleanup, console cancellation, and signed-bundle distribution require confirmed Windows x64/WHP validation and final human review.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Use the authoritative main lockfile unchanged; retain the NVX feature and all intended merge resolutions.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 27, 2026 19:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The native runtime replacement, console cancellation, and VM cleanup require confirmed Windows x64 Hypervisor Platform validation and final human review.

No open issues 🎉

Review effort: Balanced

@@ -0,0 +1,528 @@
// Copyright (c) Microsoft Corporation.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: note really sure why this had to be a .js file rather than a test file in rust. But I'll assume you had a reason.

Comment thread src/mxc-sdk/src/backends/nvx/runner.rs
@huzaifa-d
Huzaifa Danish (huzaifa-d) merged commit 1dd531d into main Oct 27, 2026
30 checks passed
@huzaifa-d
Huzaifa Danish (huzaifa-d) deleted the user/modanish/nvx-phase1-signed-integration branch October 27, 2026 21:30
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the Needs-Author-Feedback Waiting for additional information or action from the issue or pull-request author. label Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants