Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The security fix lacks the required CI-wired functional regression verifying rejection through the executor before workload execution or host permission changes.
1 open issue
What changed in this PR
This PR rejects embedded NUL characters in container identities to prevent truncating Windows string conversions from mapping distinct IDs to the same security identity.
Changes:
- Rejects NUL-containing container IDs during request normalization and adds defensive Windows backend checks.
- Adds parser and SID-derivation unit tests.
- Documents the identity restriction and warns about truncation in
to_wide.
| File | Description |
|---|---|
src/mxc-sdk/src/core/mxc_common/string_util.rs |
Documents truncation and security-identity risks. |
src/mxc-sdk/src/core/mxc_common/config_parser.rs |
Rejects embedded NUL IDs and adds parser tests. |
src/mxc-sdk/src/backends/wslc/common/wsl_container_runner.rs |
Rejects embedded NUL IDs before session-name conversion. |
src/mxc-sdk/src/backends/process_container/common/sandbox_tracking.rs |
Guards SID derivation against embedded NUL identities. |
src/mxc-sdk/src/backends/process_container/common/appcontainer_runner.rs |
Guards AppContainer identity conversion and adds regression tests. |
docs/schema.md |
Explains the container ID restriction. |
Review effort: Balanced
The scheduled area writes the six-character JSON escape and requires the executor to reject it before the workload runs. A normal id is the positive control. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b49d2002-1870-442a-b920-779f4ac7edd8
Keep the rejection. Current main removed the AppContainer fallback and the old processcontainer suite, so the scheduled regression now lives in the contract tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b49d2002-1870-442a-b920-779f4ac7edd8
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
🔗 References
🔍 Validation
✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see pull request builds)📋 Issue Type
GitHub Actions runs the PR validation build automatically. The ADO pipeline
(
MXC-PR-Build) is the Azure version of the PR pipeline, kept in parity with the GitHubActions build; it runs on merge to
main, and Microsoft reviewers with write access can trigger iton a PR with
/azp run. See pull request builds.If the
dependency-feed-checkcheck fails on a new dependency, the crate must be added tothe feed before the PR can pass. See pull request builds
for the steps.
Microsoft Reviewers: Open in CodeFlow