Skip to content

Fix: preserve Python variable name for returned input aliases #2788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aniketsy wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix: preserve Python variable name for returned input aliases #2788

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2dc703
Fix: preserve Python variable name for returned input aliases
Aniketsy Feb 2, 2026
ee6eed8
Merge remote-tracking branch 'upstream/main' into fix-2714
Aniketsy Feb 3, 2026
90b45cc
Fix: preserve Python variable name for returned input aliases
Aniketsy Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions onnxscript/_internal/converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1101,11 +1101,14 @@ def ret(exp, i, suffix):
if val.value.is_graph_input():
# In ONNX, a graph-input cannot be an output of the graph.
# We need to insert a copy.
return_var = self._emit_copy(return_var, preferred_name)
suggested_name = preferred_name
if isinstance(exp, ast.Name):
suggested_name = exp.id
Copy link
Collaborator

@gramalingam gramalingam Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A unit test would make it clear what this does. It sounds reasonable to me, but would be good to see it illustrated with an example. Specifically, if this is returning an input called X, the output cannot also be called X. Would it get renamed into something like "X_1" ?

return_var = self._emit_copy(return_var, suggested_name)
for prev_output in self._current_fn.outputs:
if prev_output.name == return_var.name:
# ONNX does not allow duplicate output names.
return_var = self._emit_copy(return_var, f"{return_var}_copy")
return_var = self._emit_copy(return_var, f"{return_var.name}_copy")
break
if self.returntype is not None:
set_type_info(return_var, self.returntype[i])
Expand Down
Loading