Support outer scope value reference in script#2831
Merged
gramalingam merged 2 commits intomainfrom Feb 26, 2026
Merged
Conversation
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2831 +/- ##
=======================================
Coverage 71.78% 71.78%
=======================================
Files 239 239
Lines 28989 29018 +29
Branches 2859 2864 +5
=======================================
+ Hits 20809 20831 +22
- Misses 7209 7214 +5
- Partials 971 973 +2 ☔ View full report in Codecov by Sentry. |
justinchuby
approved these changes
Feb 26, 2026
xadupre
approved these changes
Feb 26, 2026
Collaborator
|
@gramalingam there's some lint errors |
justinchuby
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends onnxscript scripts to allow references to ir.Values defined outside the function. This allows the use of script functions within the construction of graphs using a GraphBuilder.