virt_mshv_vtl: Report all crash_ctl bits as supported (#2822)#2824
Open
smalis-msft wants to merge 1 commit intomicrosoft:release/1.7.2511from
Open
virt_mshv_vtl: Report all crash_ctl bits as supported (#2822)#2824smalis-msft wants to merge 1 commit intomicrosoft:release/1.7.2511from
smalis-msft wants to merge 1 commit intomicrosoft:release/1.7.2511from
Conversation
This allows guests to report more information to us during a crash. We don't have to do anything based on the values of these bits, we were already logging them, they were just always 0.
github-actions
bot
added
the
release_1.7.2511
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables OpenHCL to advertise support for additional crash control bits when guests read the HV_X64_MSR_GUEST_CRASH_CTL MSR. This allows guests to provide more diagnostic information during crash reporting without requiring OpenHCL to take any additional action. The change is straightforward and low-risk - it simply advertises more capabilities to the guest that OpenHCL was already logging.
Changes:
- Updated the comment for clarity to specify "previously written value" instead of "current value"
- Added
with_no_crash_dump(true)to advertise support for the no_crash_dump bit - Added
with_pre_os_id(0b111)to advertise support for all pre_os_id values (0-7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows guests to report more information to us during a crash. We don't have to do anything based on the values of these bits, we were already logging them, they were just always 0.
Clean cherry-pick