Repository navigation
chore(codegen): generate the public TypedDicts from the docs - #3247
Open
Pavel Feldman (pavelfeldman) wants to merge 1 commit into
Open
Pavel Feldman (pavelfeldman) wants to merge 1 commit into
Pavel Feldman (pavelfeldman) wants to merge 1 commit into
Conversation
- The generator writes playwright/_impl/_api_structures.py (`--flavor structs`): every struct that the API uses, nested ones included. update_api.sh runs it. - The internal types move to the hand-written playwright/_impl/_internal_structures.py. - python_rules.js names the nested storage state structs, and keeps the shipped `total=` of 5 TypedDicts (structTotal). - compare_api.py compares TypedDicts. Against the hand-written file it finds no difference; the text diff only reorders the DropPayload.files union. - legacy_order.json keeps the hand-written class order, so that the diff is small.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
playwright/_impl/_api_structures.pyfrom the docs, nested structs included. The internal types move to the hand-written_impl/_internal_structures.py.python_rules.jsnames the nested storage state structs and keeps the shippedtotal=of 5 TypedDicts (structTotal).legacy_order.jsonkeeps today's class order, so the diff shows only the moved internal types and the order inside theDropPayload.filesunion.compare_api.pynow compares TypedDicts too and finds no difference.