Skip to content

feat(test-runner): add {testFileBaseName} token to snapshotPathTemplate#40466

Open
devareddy05 wants to merge 1 commit intomicrosoft:mainfrom
devareddy05:feat-24171
Open

feat(test-runner): add {testFileBaseName} token to snapshotPathTemplate#40466
devareddy05 wants to merge 1 commit intomicrosoft:mainfrom
devareddy05:feat-24171

Conversation

@devareddy05
Copy link
Copy Markdown
Contributor

Summary

  • Adds a new {testFileBaseName} token to snapshotPathTemplate, expanding to the test file name without its last extension (matches path.parse().name).
  • Sample: for a test file page/page-click.spec.ts, {testFileBaseName} resolves to page-click.spec. The existing {testFileName} keeps producing page-click.spec.ts.
  • Useful on Windows where a test file 01-render.test.ts and a sibling snapshot folder of the same name collide; users can now write {testFileDir}/{testFileBaseName}-snapshots/{arg}{ext} to drop the trailing extension.
  • Extended the existing tokens should expand property test in snapshot-path-template.spec.ts rather than adding a new test.

Fixes #24171

@github-actions
Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:395 › should copy network request @windows-latest-node20

15 flaky ⚠️ [installation tests] › connect-to-selenium.spec.ts:20 › connect to selenium `@package-installations-ubuntu-latest`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:449 › should be able to connect via localhost `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/video.spec.ts:682 › screencast › should capture full viewport on hidpi `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:449 › should be able to connect via localhost `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/popup.spec.ts:261 › should not throw when click closes popup `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:449 › should be able to connect via localhost `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-page] › page/page-request-continue.spec.ts:754 › propagate headers cross origin redirect after interception `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:449 › should be able to connect via localhost `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:449 › should be able to connect via localhost `@chromium-ubuntu-22.04-node22`
⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:224 › cli codegen › should generate frame locators (4) `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:433 › should work behind reverse proxy `@windows-latest-node20`

41463 passed, 847 skipped


Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

Test results for "MCP"

5 failed
❌ [chromium] › mcp/dashboard.spec.ts:347 › save recording streams WebM bytes to the chosen file @mcp-windows-latest
❌ [firefox] › mcp/cli-devtools.spec.ts:204 › video-start-stop @mcp-windows-latest
❌ [firefox] › mcp/cli-devtools.spec.ts:218 › video-chapter @mcp-windows-latest
❌ [chrome] › mcp/mouse.spec.ts:69 › browser_mouse_click_xy (default) @mcp-macos-latest
❌ [webkit] › mcp/dashboard.spec.ts:185 › should start dashboard and annotate when no dashboard is running @mcp-macos-latest

6803 passed, 927 skipped


Merge workflow run.

@devareddy05
Copy link
Copy Markdown
Contributor Author

Test results for "MCP"

5 failed ❌ [chromium] › mcp/dashboard.spec.ts:347 › save recording streams WebM bytes to the chosen file @mcp-windows-latest ❌ [firefox] › mcp/cli-devtools.spec.ts:204 › video-start-stop @mcp-windows-latest ❌ [firefox] › mcp/cli-devtools.spec.ts:218 › video-chapter @mcp-windows-latest ❌ [chrome] › mcp/mouse.spec.ts:69 › browser_mouse_click_xy (default) @mcp-macos-latest ❌ [webkit] › mcp/dashboard.spec.ts:185 › should start dashboard and annotate when no dashboard is running @mcp-macos-latest

6803 passed, 927 skipped

Merge workflow run.

Hi maintainers @Skn0tt,

I believe the Chromium failure might be flaky, it’s been passing consistently in my local setup without issues.

Happy to add a changeset, rebase, or make any adjustments as needed. Thanks for taking a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add testFilePathName to snapshotPathTemplate (without extension)

1 participant