Skip to content

feat(recorder): Shift+click to interact with page during Pick Locator#40564

Open
jameskip wants to merge 1 commit intomicrosoft:mainfrom
jameskip:shift-click-pick-locator-bypass
Open

feat(recorder): Shift+click to interact with page during Pick Locator#40564
jameskip wants to merge 1 commit intomicrosoft:mainfrom
jameskip:shift-click-pick-locator-bypass

Conversation

@jameskip
Copy link
Copy Markdown

@jameskip jameskip commented May 1, 2026

Summary

  • Allow holding Shift during Pick Locator mode to bypass locator selection and interact with the page directly
  • When Shift is held, mouse events pass through to the page (clicks, pointer events, mouse moves)
  • When Shift is released, Pick Locator resumes normally — no mode toggling required
  • Highlight/tooltip clears while Shift is held to give visual feedback

Issue #33280

Test plan

  • Added test should shift-click to interact with page while picking locator that verifies:
    • Shift+click triggers the page's click handler
    • Regular click (without Shift) still picks the locator
  • Existing pick locator tests continue to pass

…ocator mode

When the Pick Locator tool is active, holding Shift now lets mouse events
pass through to the page instead of being consumed for locator selection.
This allows users to interact with the page (e.g., open dropdowns, click
buttons) without leaving Pick Locator mode, then release Shift to resume
picking.

Fixes microsoft#33280

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jameskip
Copy link
Copy Markdown
Author

jameskip commented May 1, 2026

@jameskip please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant