Skip to content

fix(esm): strip stylesheet imports #40581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rkdfx wants to merge 1 commit into
base: main
Choose a base branch
from
+48 −15
Open

fix(esm): strip stylesheet imports #40581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions packages/playwright/src/transform/babelBundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,23 +78,23 @@ function babelTransformOptions(isTypeScript: boolean, isModule: boolean, plugins
...(jsxImportSource ? { importSource: jsxImportSource } : {}),
}]);

if (!isModule) {
// Note: we used to include '@babel/plugin-transform-dynamic-import' to convert async imports
// into require(), so that pirates can intercept them. With the ESM loader enabled by default,
// there is no need for this.
if (!isModule)
plugins.push([require('@babel/plugin-transform-modules-commonjs')]);
// Note: we used to include '@babel/plugin-transform-dynamic-import' to convert async imports
// into require(), so that pirates can intercept them. With the ESM loader enabled by default,
// there is no need for this.
plugins.push([
(): PluginObj => ({
name: 'css-to-identity-obj-proxy',
visitor: {
ImportDeclaration(path: NodePath<ImportDeclaration>) {
if (path.node.source.value.match(/\.(css|less|scss)$/))
path.remove();
}

plugins.push([
(): PluginObj => ({
name: 'css-to-identity-obj-proxy',
visitor: {
ImportDeclaration(path: NodePath<ImportDeclaration>) {
if (path.node.source.value.match(/\.(css|less|sass|scss|styl)$/))
path.remove();
}
})
]);
}
}
})
]);

return {
browserslistConfigFile: false,
Expand Down
33 changes: 33 additions & 0 deletions tests/playwright-test/loader.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1086,6 +1086,39 @@ test('should remove import css', async ({ runInlineTest }) => {
expect(result.passed).toBe(1);
});

test('should remove stylesheet imports in esm mode', {
annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/39187' },
}, async ({ runInlineTest }) => {
const result = await runInlineTest({
'package.json': JSON.stringify({ type: 'module' }),
'a.test.ts': `
import './styles.scss';
import './styles.sass';
import './styles.less';
import './styles.styl';
import './styles.css';
import { helper } from './helper.ts';

import { test, expect } from '@playwright/test';
test('pass', async () => {
expect(helper).toBe(42);
});
`,
'helper.ts': `
import './nested.scss';
export const helper = 42;
`,
'styles.scss': `@use 'sass:math'; .foo { color: red; }`,
'styles.sass': `.foo\n color: red`,
'styles.less': `@primary: red; .foo { color: @primary; }`,
'styles.styl': `.foo\n color red`,
'styles.css': `.foo { color: red; }`,
'nested.scss': `@import 'foo'; .bar { color: blue; }`,
});
expect(result.exitCode).toBe(0);
expect(result.passed).toBe(1);
});

test('should dynamically import re-exported cjs namespace', {
annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/35812' },
}, async ({ runInlineTest }) => {
Expand Down