fix(webview): intercept subframe document requests before frame is known#41332
Open
yury-s wants to merge 2 commits into
Open
fix(webview): intercept subframe document requests before frame is known#41332yury-s wants to merge 2 commits into
yury-s wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Stock WebKit RDP has no Page.frameAttached, so a subframe's document request arrives before Page.frameNavigated creates its frame. The request was dropped, which stalled intercepted subframe loads (the route handler never ran). Let such a request through frameless: requestStarted (and the inflight helpers / requestFailed) now tolerate a null frame and skip the per-frame bookkeeping, so the route still fulfills/continues it. The frame is created normally once Page.frameNavigated arrives.
yury-s
force-pushed
the
fix-webview-subframe-interception
branch
from
4f739f2 to
6018b71
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Intercepting subframe document requests lets the selectors-frame / locator-frame route-based tests load their iframes, so unskip the 26 that now pass. Still skipped: the smoke/nested/$ variants that fulfill the main navigation (flaky iOS 26 main-nav interception), the COEP/COOP/CORP isolated iframe (out-of-process), and locator.contentFrame / frameLocator.owner.
dgozman
approved these changes
Jun 17, 2026
Contributor
Test results for "MCP"7354 passed, 1122 skipped Merge workflow run. |
Contributor
Test results for "tests 1"Warning The triggering workflow run ended with status 4 flaky39544 passed, 739 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Page.frameAttached, so a subframe's document request arrives beforePage.frameNavigatedcreates its frame. The request was dropped, which stalled intercepted subframe loads (the route handler never ran).frameManager.requestStarted(and the inflight helpers /requestFailed) now tolerate a null frame and skip the per-frame bookkeeping, so the route still fulfills/continues it. The frame is created normally oncePage.frameNavigatedarrives.