Skip to content

test(webkit): update webkit-wsl launch expectations for executablePath #41334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yury-s wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −6
Open

test(webkit): update webkit-wsl launch expectations for executablePath #41334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions tests/library/browsertype-launch.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,18 +64,15 @@ it('should throw if page argument is passed', async ({ browserType, browserName,
it('should reject if launched browser fails immediately', async ({ mode, browserType, asset, channel }) => {
const error = await browserType.launch({ executablePath: asset('dummy_bad_browser_executable.js') }).catch(e => e);
if (channel === 'webkit-wsl')
expect(error.message).toContain('Cannot specify executablePath when using the \"webkit-wsl\" channel.');
expect(error.message).toContain('Failed to launch');
else
expect(error.message).toMatch(/browserType\.launch(.|\n)*(spawn UNKNOWN|spawn EFTYPE|Browser logs:)/gim);
});

it('should reject if executable path is invalid', async ({ browserType, mode, channel }) => {
it('should reject if executable path is invalid', async ({ browserType, mode }) => {
let waitError: Error | undefined;
await browserType.launch({ executablePath: 'random-invalid-path' }).catch(e => waitError = e);
if (channel === 'webkit-wsl')
expect(waitError!.message).toContain('Cannot specify executablePath when using the \"webkit-wsl\" channel.');
else
expect(waitError!.message).toContain('Failed to launch');
expect(waitError!.message).toContain('Failed to launch');
});

it('should handle timeout', async ({ browserType, mode }) => {
Expand Down
Loading