devops(electron): suppress macOS reopen windows prompt in tests#41344
Merged
dgozman merged 1 commit intoJun 17, 2026
Conversation
Tests spawn many Electron instances and kill them with SIGINT. After enough abnormal exits of the same bundle id, macOS shows a modal asking to reopen windows, which is handled inside the AppleEvent handler before launch finishes and hangs app.whenReady() until the fixtures time out. Disable the persistent-UI machinery on macOS, mirroring electron/electron@c16c6da
Contributor
Test results for "MCP"7354 passed, 1122 skipped Merge workflow run. |
Contributor
Test results for "tests 1"2 flaky39607 passed, 743 skipped Merge workflow run. |
yury-s
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary