validate import checks in python course environment setup - #3538
Draft
Dhairya Patel (HABER7789) wants to merge 2 commits into
Draft
validate import checks in python course environment setup#3538Dhairya Patel (HABER7789) wants to merge 2 commits into
Dhairya Patel (HABER7789) wants to merge 2 commits into
Conversation
Module names from course.json flowed into a `python -c` command line without validation, so a drop-in course could run random Python when someone ran the environment check. They now have to be dotted identifiers, and anything else is reported as a failed check rather than silently dropped. Also fixes the multiple-environments warning, which joined the environment objects directly and so logged [object Object] instead of their names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module names from course.json flowed into a
python -ccommand line without validation, so a drop-in course could run random Python when someone ran the environment check. They now have to be dotted identifiers, and anything else is reported as a failed check rather than silently dropped.Also fixes the multiple-environments warning, which joined the environment objects directly and so logged
[object Object]instead of their names.