Prevent code meant only for simulation from leaking into generated quantum programs and analysis - #3540
Open
Ian Davis (idavis) wants to merge 1 commit into
Open
Prevent code meant only for simulation from leaking into generated quantum programs and analysis#3540Ian Davis (idavis) wants to merge 1 commit into
Ian Davis (idavis) wants to merge 1 commit into
Conversation
…antum programs and analysis
Ian Davis (idavis)
marked this pull request as ready for review
August 3, 2026 15:24
Ian Davis (idavis)
requested review from
Andrew Casey (amcasey) and
Stefan J. Wernli (swernli)
as code owners
August 3, 2026 15:24
|
|
||
| /// Intrinsic names that partial evaluation handles as code generation no-ops. | ||
| pub const CODEGEN_NOOP_INTRINSIC_NAMES: &[&str] = &[ | ||
| "DumpRegister", |
There was a problem hiding this comment.
Without really understanding what this list refers to, it surprises me that DumpRegister and DumpOperation would be present, but DumpMachine would be absent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change prevents code meant only for simulation from leaking into generated quantum programs and FIR transform analysis.
What changed
DumpOperationandFactas operations that produce no generated code.Why
Simulation helpers may contain fallback code that works in the simulator but cannot be emitted as part of a target program. Processing that code caused compiler failures or references to operations that did not exist at runtime.
The compiler now removes those fallback bodies at the correct boundary while leaving normal simulation behavior unchanged.