Fix lint issues in qlib/utils/ (W1309, W0612)#2144
Closed
Bortlesboat wants to merge 1 commit intomicrosoft:mainfrom
Closed
Fix lint issues in qlib/utils/ (W1309, W0612)#2144Bortlesboat wants to merge 1 commit intomicrosoft:mainfrom
Bortlesboat wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…ithout interpolation (W1309) and prefix unused variable with underscore (W0612) Contributes to microsoft#1007 - Remove unnecessary f-string prefix from 16 string literals across index_data.py, mod.py, objm.py, and time.py that had no interpolated variables (pylint W1309: f-string-without-interpolation) - Prefix unused variable `lft_etd` with underscore in data.py to indicate it is intentionally unused (pylint W0612: unused-variable) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
@microsoft-github-policy-service agree |
1 similar comment
Author
|
@microsoft-github-policy-service agree |
Author
|
Closing this — the lint fixes are low-priority and I'd rather focus on the substantive bug fix in #2161. Apologies for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fprefix from 16 string literals inqlib/utils/that contain no interpolated variables (pylint W1309:f-string-without-interpolation)lft_etdwith underscore inqlib/utils/data.pyto indicate it is intentionally unused (pylint W0612:unused-variable)Contributes to #1007
Details
Files changed:
qlib/utils/index_data.py— 7 f-string fixesqlib/utils/objm.py— 7 f-string fixesqlib/utils/mod.py— 1 f-string fixqlib/utils/time.py— 1 f-string fixqlib/utils/data.py— 1 unused variable fix (lft_etd→_lft_etd)All changes are safe cosmetic/lint fixes with no behavioral impact. The existing flake8 and pylint CI checks continue to pass, and the previously-disabled W1309 and W0612 rules now pass cleanly for
qlib/utils/.Test plan
flake8passes with project config (make flake8equivalent)pylintpasses with project config (make pylintequivalent)qlib/utils/qlib/utils/🤖 Generated with Claude Code