fix(workflow): correct filelock path for file:// URIs#2169
Open
warren618 wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(workflow): correct filelock path for file:// URIs#2169warren618 wants to merge 1 commit intomicrosoft:mainfrom
warren618 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
For file:///home/user/.../mlruns, urlparse gives netloc="" and
path="/home/user/.../mlruns". The previous code used lstrip("/") which
stripped the leading slash, making the path relative. os.path.join then
resolved it relative to cwd, producing a doubled path like:
/home/user/project/home/user/project/mlruns/filelock
Use pr.netloc + pr.path directly to preserve the absolute path.
Fixes microsoft#2129
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2129
For
file:///home/user/project/mlruns,urlparsegivesnetloc=""andpath="/home/user/project/mlruns". The previous code usedpr.path.lstrip("/")which stripped the leading/, making the path relative.os.path.join("", "home/user/...", "filelock")then resolved it relative to cwd, producing a doubled path:Fix
Preserves the absolute path from the URI directly.