fix: thread freq parameter from backtest() through to Account#2176
Open
EdenRochmanSharabi wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: thread freq parameter from backtest() through to Account#2176EdenRochmanSharabi wants to merge 1 commit intomicrosoft:mainfrom
EdenRochmanSharabi wants to merge 1 commit intomicrosoft:mainfrom
Conversation
) Previously create_account_instance() did not accept a freq parameter, so Account always initialized with the default freq='day' regardless of the actual backtest frequency. Add freq parameter to create_account_instance(), get_strategy_executor(), backtest(), and collect_data(), threading it through to Account() construction. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1846. The
freqparameter was hardcoded to'day'in Account creation. Now threaded from backtest config.