Skip to content

Fix Windows build and IDL generated-project tests#260

Merged
linmajia merged 3 commits into
microsoft:masterfrom
linmajia:fix-build-errors
Jun 30, 2026
Merged

Fix Windows build and IDL generated-project tests#260
linmajia merged 3 commits into
microsoft:masterfrom
linmajia:fix-build-errors

Conversation

@linmajia

Copy link
Copy Markdown
Contributor

Summary

This PR fixes Windows build failures caused by min/max macro conflicts and ensures IDL-generated test projects can locate external thrift/protobuf dependencies when built from the test scratch directory.

Changes

  • Made std::numeric_limits<T>::max() calls macro-safe on Windows.
  • Made remaining std::min(...) usages macro-safe.
  • Printed the generated counter project MSBuild log when IDL codegen tests fail.
  • Passed built thrift/protobuf include and library directories into generated-project CMake configuration.
  • Added diagnostics when expected generated-project dependency directories are missing.

Validation

  • Full Windows, Linux, and macOS test suite passed.

@linmajia linmajia merged commit fd471d5 into microsoft:master Jun 30, 2026
2 checks passed
@linmajia linmajia deleted the fix-build-errors branch June 30, 2026 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant