fix: wire up enableFocusRing prop for TextInput#2870
Draft
Saadnajmi wants to merge 1 commit intomicrosoft:mainfrom
Draft
fix: wire up enableFocusRing prop for TextInput#2870Saadnajmi wants to merge 1 commit intomicrosoft:mainfrom
Saadnajmi wants to merge 1 commit intomicrosoft:mainfrom
Conversation
|
99b73a8 to
6b46e97
Compare
Saadnajmi
commented
Mar 23, 2026
packages/react-native/Libraries/Text/TextInput/RCTBaseTextInputViewManager.mm
Show resolved
Hide resolved
Forward enableFocusRing prop to the native TextInput view — it was missing from the view manager. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2a64ffd to
4d9e6ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enableFocusRingprop to the native TextInput view — it was missing from the view config and view managerTest plan
enableFocusRing={false}on a<TextInput>and verify no focus ring appears on focus🤖 Generated with Claude Code