Skip to content

Harden perf-comment workflow inputs #16174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vineethkuttan wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −2
Open

Harden perf-comment workflow inputs #16174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .github/workflows/perf-comment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ jobs:
exit 0
fi
PR_NUMBER=$(cat "$PR_FILE" | tr -d '[:space:]')
# Validate: must be a positive integer to prevent injection via artifact poisoning
if ! echo "$PR_NUMBER" | grep -qE '^[1-9][0-9]*$'; then
echo "::error::Invalid PR number in artifact: not a positive integer"
exit 1
fi
echo "number=$PR_NUMBER" >> "$GITHUB_OUTPUT"
echo "skip=false" >> "$GITHUB_OUTPUT"

Expand All @@ -58,12 +63,20 @@ jobs:
- name: Post or update PR comment
if: steps.pr.outputs.skip != 'true' && steps.report.outputs.skip != 'true'
uses: actions/github-script@v7
env:
REPORT_PATH: ${{ steps.report.outputs.path }}
PR_NUMBER: ${{ steps.pr.outputs.number }}
with:
script: |
const fs = require('fs');
const marker = '<!-- rnw-perf-results -->';
const reportPath = '${{ steps.report.outputs.path }}';
const prNumber = parseInt('${{ steps.pr.outputs.number }}', 10);
const reportPath = process.env.REPORT_PATH;
const prNumber = parseInt(process.env.PR_NUMBER, 10);

if (!Number.isInteger(prNumber) || prNumber <= 0) {
core.setFailed('Invalid PR number from artifact — possible artifact poisoning.');
return;
}

const markdown = fs.readFileSync(reportPath, 'utf-8');
const body = `${marker}\n${markdown}`;
Expand Down