Skip to content

Model Azure Monitor as an incident platform - #315

Open
Deepthi Chelupati (dm-chelupati) wants to merge 1 commit into
update/stable-sre-agent-apifrom
fix/azmonitor-incident-platform
Open

Model Azure Monitor as an incident platform#315
Deepthi Chelupati (dm-chelupati) wants to merge 1 commit into
update/stable-sre-agent-apifrom
fix/azmonitor-incident-platform

Conversation

@dm-chelupati

Copy link
Copy Markdown
Collaborator

Summary

  • remove the incorrect Azure Monitor connector toggles and resources from Bicep, Terraform, recipes, and labs
  • retain App Insights and Log Analytics as data connectors
  • retain Azure Monitor as the AzMonitor incident platform
  • ignore legacy AzureMonitor and MonitorClient child projections during export
  • correct incident-filter defaults and documentation

Validation

  • Bash and PowerShell export parity for enterprise-aks-sre
  • exports retain Log Analytics and AzMonitor while excluding Azure Monitor connector fields
  • Bicep compilation and compiled ARM semantic parity
  • Terraform formatting and validation
  • shell, PowerShell, Python, and JSON syntax checks

This PR is stacked on #312 and should be rebased onto main after #312 merges. No Azure resources were modified during validation.

Comment on lines -234 to -235
#disable-next-line BCP081
resource azureMonitorConnector 'Microsoft.App/agents/connectors@2025-05-01-preview' = {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work if you removed it? it's some dev debt I need to clean up server side but is removing this resulting in app insights still working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants