Bugfix - gpu_stream: remove ROCm build support, require CUDA with NVML#789
Open
Bugfix - gpu_stream: remove ROCm build support, require CUDA with NVML#789
Conversation
gpu_stream depends on NVML (nvidia-ml) for GPU monitoring which is NVIDIA-specific and has no ROCm equivalent. Remove the ROCm/HIP build path and skip the build cleanly when CUDA is not found.
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the broken ROCm/HIP build path for the gpu_stream benchmark, making it CUDA-only with a graceful warning when CUDA is not found.
Changes:
- Replaced the non-functional ROCm/HIP build path and
FATAL_ERRORfallback with aWARNINGmessage andreturn() - No changes to the CUDA build path
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #789 +/- ##
=======================================
Coverage 85.70% 85.70%
=======================================
Files 102 102
Lines 7703 7703
=======================================
Hits 6602 6602
Misses 1101 1101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The gpu_stream benchmark has NVIDIA-specific dependencies that prevent it from compiling on ROCm 6.3+. This change makes it CUDA-only, gracefully skipping the build with a warning on non-NVIDIA
environments.
Problem
The gpu_stream benchmark fails to compile on ROCm 6.3+ due to multiple NVIDIA-specific dependencies:
.cu source files are), so they fail to resolve on ROCm.
6.3, causing compilation errors after hipification.
The existing ROCm path was marked as incomplete (# TODO: test for ROC) and was never fully functional on recent ROCm versions.
Changes
Impact