Add compile-time type checking to TypeScript template dev scripts#2767
Open
heyitsaamir wants to merge 3 commits intomainfrom
Open
Add compile-time type checking to TypeScript template dev scripts#2767heyitsaamir wants to merge 3 commits intomainfrom
heyitsaamir wants to merge 3 commits intomainfrom
Conversation
tsx was causing issues, switch to nodemon + ts-node for the dev script across all 5 TypeScript templates (echo, ai, graph, mcp, mcpclient). Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the TypeScript app templates’ developer experience by replacing tsx watch with a nodemon + ts-node based dev loop, and adjusting template dependencies accordingly.
Changes:
- Replaced
devscript fromtsx watch ...tonodemon ... --exec "ts-node ..."across 5 TS templates. - Removed
tsxdevDependency and addednodemon+ts-nodedevDependencies in those templates.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/cli/templates/typescript/echo/package.json.hbs | Switches dev script to nodemon+ts-node; updates devDependencies. |
| packages/cli/templates/typescript/ai/package.json.hbs | Switches dev script to nodemon+ts-node; updates devDependencies. |
| packages/cli/templates/typescript/graph/package.json.hbs | Switches dev script to nodemon+ts-node; updates devDependencies. |
| packages/cli/templates/typescript/mcp/package.json.hbs | Switches dev script to nodemon+ts-node; updates devDependencies (also contains an invalid multi-line script string). |
| packages/cli/templates/typescript/mcpclient/package.json.hbs | Switches dev script to nodemon+ts-node; updates devDependencies. |
Use concurrently to run tsx watch + tsc --noEmit --watch in parallel, giving fast hot reload and type errors in the same terminal. Adds dev:run and dev:check scripts for running them individually. Co-Authored-By: Claude <noreply@anthropic.com>
heyitsaamir
changed the title
Comment on lines
19
to
20
| "inspect": "npx cross-env SERVER_PORT=9000 npx @modelcontextprotocol/inspector -e NODE_NO_WARNINGS=1 -e PORT=3978 node | ||
| -r dotenv/config ." |
There was a problem hiding this comment.
[CRITICAL] scripts.inspect string contains a literal newline (between node and -r ...), which makes the generated package.json invalid JSON and will break npm install/npm run inspect. Put the command on a single line (or otherwise avoid unescaped newlines inside JSON strings).
Suggested change
| "inspect": "npx cross-env SERVER_PORT=9000 npx @modelcontextprotocol/inspector -e NODE_NO_WARNINGS=1 -e PORT=3978 node | |
| -r dotenv/config ." | |
| "inspect": "npx cross-env SERVER_PORT=9000 npx @modelcontextprotocol/inspector -e NODE_NO_WARNINGS=1 -e PORT=3978 node -r dotenv/config ." |
Put the inspect command on a single line to avoid invalid JSON in the generated package.json. Co-Authored-By: Claude <noreply@anthropic.com>
rido-min
approved these changes
Apr 21, 2026
rido-min
reviewed
Apr 21, 2026
| "start": "node .", | ||
| "dev": "tsx watch -r dotenv/config src/index.ts" | ||
| "dev": "concurrently \"tsx watch -r dotenv/config src/index.ts\" \"tsc --noEmit --watch\"", | ||
| "dev:run": "tsx watch -r dotenv/config src/index.ts", |
Member
There was a problem hiding this comment.
why not using the --env-file flag?
the -r dotnev/config seems obscure and dated in 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
concurrentlyto runtsx watchandtsc --noEmit --watchin parallel duringnpm run devdev:runanddev:checkscripts for running them individuallyTest plan
npm run devtscreports it in the terminal