Draft
Conversation
…configurations - Introduced `SkipIfAgentic()` method to skip tests incompatible with agentic identity in CompatTeamsInfoTests. - Updated all relevant tests to use [SkippableFact] with a timeout of 60 seconds. - Enhanced CreateConversationDiagnosticTests to set AgenticIdentity in HTTP requests. - Modified ConversationClientTests and CreateConversationTests to include agentic properties in activities. - Added methods in IntegrationTestFixture to retrieve ConversationAccount and AgenticIdentity. - Included Xunit.SkippableFact package for dynamic test skipping. - Updated xunit.runner.json to disable test collection parallelization to prevent token cache conflicts.
Enable agentic identity propagation in the Teams Bot Compat layer by extracting AgenticIdentity from activity properties and passing it through CompatConversations to all relevant API calls. Update tests to support agentic scenarios by removing SkipIfAgentic logic, using [Fact] for all tests, and including agentic properties in test setup. This improves support for delegated access and agentic app scenarios across both runtime and tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for passing an optional
AgenticIdentityparameter to various API client methods across the codebase. This enables user-delegated token acquisition and allows the bot to act on behalf of an agentic app when required. The changes are primarily focused on extending method signatures, updating internal calls, and propagating the identity through the compatibility layer.AgenticIdentity support across API clients:
ActivityClient,ConversationApiClient,MeetingClient,MemberClient,ReactionClient, andTeamClientto accept an optionalAgenticIdentityparameter and pass it to underlying client calls. [1] [2] [3] [4] [5] [6] [7] [8]Compatibility layer enhancements:
AgenticIdentityas a property ofCompatConversations, populated from incoming activity properties, and ensured it is passed to all relevant internal client method calls. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Code maintenance and imports:
using Microsoft.Teams.Bot.Core.Schema;in several files to support the new parameter. [1] [2] [3]CompatConversations.These changes collectively ensure agentic identity information can be consistently and securely propagated for user-delegated scenarios.
bot-agent-integrationtests.md