Skip to content

Remove with_reply_to_id method #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corinagum merged 1 commit into from
Apr 13, 2026
Merged

Remove with_reply_to_id method #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/api/src/microsoft_teams/api/models/activity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,6 @@ def with_id(self, value: str) -> Self:
self.id = value
return self

Comment thread
corinagum marked this conversation as resolved.
def with_reply_to_id(self, value: str) -> Self:
"""Set the reply_to_id."""
self.reply_to_id = value
return self

def with_channel_id(self, value: ChannelID) -> Self:
"""Set the channel_id."""
self.channel_id = value
Expand Down
2 changes: 0 additions & 2 deletions packages/api/tests/unit/test_activity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ def test_should_build(
activity = (
test_activity.with_locale("en")
.with_recipient(bot)
.with_reply_to_id("3")
.with_service_url("http://localhost")
.with_timestamp(datetime.now())
.with_local_timestamp(datetime.now())
Expand All @@ -75,7 +74,6 @@ def test_should_build(
assert activity.from_ == user
assert activity.conversation == chat
assert activity.recipient == bot
assert activity.reply_to_id == "3"
assert activity.service_url == "http://localhost"
assert activity.timestamp is not None
assert activity.local_timestamp is not None
Expand Down
Loading