Skip to content

Send notifications even when we're unpackaged #20013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlos-zamora merged 2 commits into from
Mar 25, 2026
+22 −4
Merged

Send notifications even when we're unpackaged #20013

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a0dd78
Send notifications even when we're unpackaged
carlos-zamora Mar 25, 2026
fc1b724
remove WindowEmperor changes
carlos-zamora Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions src/cascadia/TerminalApp/DesktopNotification.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
#include "pch.h"
#include "DesktopNotification.h"

#include <WtExeUtils.h>

using namespace winrt::Windows::UI::Notifications;
using namespace winrt::Windows::Data::Xml::Dom;

Expand Down Expand Up @@ -96,10 +98,26 @@ namespace winrt::TerminalApp::implementation
}

// For packaged apps, CreateToastNotifier() uses the package identity automatically.
// For unpackaged apps, we need to provide an AUMID, but that case is less common
// and toast notifications may not be supported without additional setup.
auto notifier = ToastNotificationManager::CreateToastNotifier();
notifier.Show(toast);
// For unpackaged apps, we must pass the explicit AUMID that was registered
Copy link
Copy Markdown
Member

@DHowett DHowett Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you make the other block a separate PR to main, you can fold this one into #20010

// at startup via SetCurrentProcessExplicitAppUserModelID.
winrt::Windows::UI::Notifications::ToastNotifier notifier{ nullptr };
if (IsPackaged())
{
notifier = ToastNotificationManager::CreateToastNotifier();
}
else
{
// Retrieve the AUMID that was set by WindowEmperor at startup.
wil::unique_cotaskmem_string aumid;
if (SUCCEEDED(GetCurrentProcessExplicitAppUserModelID(&aumid)))
{
notifier = ToastNotificationManager::CreateToastNotifier(aumid.get());
}
}
if (notifier)
{
Comment on lines +117 to +118
Copy link
Copy Markdown
Member

@lhecker lhecker Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do those WinRT (?) functions really return null instead of throwing an HRESULT?

Copy link
Copy Markdown
Member Author

@carlos-zamora carlos-zamora Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if CreateToastNotifier() can return null, but I have trust issues haha.

It's more there for when this fails...

if (SUCCEEDED(GetCurrentProcessExplicitAppUserModelID(&aumid)))

notifier.Show(toast);
}
}
catch (...)
{
Expand Down
Loading