Skip to content

Implement UNC path mangling for OSC 7 via WSL#20094

Open
lhecker wants to merge 8 commits intomainfrom
dev/lhecker/osc-7-wsl
Open

Implement UNC path mangling for OSC 7 via WSL#20094
lhecker wants to merge 8 commits intomainfrom
dev/lhecker/osc-7-wsl

Conversation

@lhecker
Copy link
Copy Markdown
Member

@lhecker lhecker commented Apr 8, 2026 •
edited by DHowett
Loading

This is a followup of #20019 wich makes it possible
to duplicate WSL tabs with e.g. fish-shell.

The PR is somewhat large because I found that the
MangleStartingDirectoryForWSL doesn't properly
detect wsl.exe in a path with spaces. That's fixed now.

Validation Steps Performed

  • Navigate fish into some directory
  • Duplicate tab duplicates paths ✅

Closes #20108

@lhecker lhecker added Area-VT Virtual Terminal sequence support Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Priority-3 A description (P3) labels Apr 8, 2026
lhecker
lhecker commented Apr 8, 2026
View reviewed changes
Comment thread src/cascadia/TerminalSettingsModel/ActionMap.cpp
DHowett
DHowett reviewed Apr 8, 2026
View reviewed changes
Comment thread src/renderer/base/renderer.cpp Outdated
DHowett
DHowett reviewed Apr 8, 2026
View reviewed changes
Comment thread src/types/ut_types/UtilsTests.cpp Outdated
DHowett
DHowett reviewed Apr 8, 2026
View reviewed changes
Comment thread src/types/ut_types/UtilsTests.cpp Outdated
DHowett
DHowett reviewed Apr 8, 2026
View reviewed changes
Comment thread src/types/utils.cpp Outdated
DHowett
DHowett previously requested changes Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Apr 8, 2026
@DHowett DHowett mentioned this pull request Apr 14, 2026
Open
@DHowett DHowett dismissed their stale review April 14, 2026 22:25

addressed my own feedback

@DHowett DHowett requested a review from carlos-zamora April 14, 2026 22:25
@DHowett DHowett mentioned this pull request Apr 14, 2026
Merged
@DHowett
Copy link
Copy Markdown
Member

DHowett commented Apr 14, 2026

Okay, I still have some concerns.

Fish will automatically fail in instances where the WSL profile was generated with --cd ~, because we will try to start wsl.exe in \\machine\home\user and fail.

Many shells which use this new mangle format will "duplicate" properly, but they will delay launch 1-10 seconds because we try to resolve \\machine via UNC while we handle path mangling.

DHowett
DHowett requested changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 14, 2026
DHowett added a commit that referenced this pull request Apr 15, 2026
@DHowett
Revert "Implement OSC 7 for setting the CWD (#20019)" (#20116)
88a236c 
This reverts commit 7f5185e.

I have some new concerns about the fix in #20094, so I'm considering
reverting OSC 7 from 1.25.

Refs #20108
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett DHowett DHowett requested changes

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Area-VT Virtual Terminal sequence support Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Terminal freezes intermittently

2 participants

@lhecker @DHowett