Fix Settings tab color mismatch with Settings page background (Dark/Light only) - #20447
Open
Charan.k (k-charansai) wants to merge 1 commit into
Open
Fix Settings tab color mismatch with Settings page background (Dark/Light only)#20447Charan.k (k-charansai) wants to merge 1 commit into
Charan.k (k-charansai) wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the Settings tab color mismatch, addressing the visual inconsistency where the Settings tab appeared black while the Settings page was dark gray.
Looking at the history of the original fix (#19999) and its subsequent revert (#20292 / #20186), it appears the accessibility/contrast concern was isolated to the HighContrast theme change (
SystemControlBackgroundBaseLowBrush→SystemColorWindowBrush).To address the original issue while avoiding the accessibility regression, this patch reapplies only the Dark and Light theme softening and leaves the HighContrast theme exactly as it is on
maintoday.Changes
SettingsUiTabBrushfrom#0c0c0cto#282828to match the Settings page background.SettingsUiTabBrushfrom#ffffffto#F9F9F9.Closes #19873