Skip to content

Fix Settings tab color mismatch with Settings page background (Dark/Light only) - #20447

Open
Charan.k (k-charansai) wants to merge 1 commit into
microsoft:mainfrom
k-charansai:fix/19873-settings-tab-color
Open

Fix Settings tab color mismatch with Settings page background (Dark/Light only)#20447
Charan.k (k-charansai) wants to merge 1 commit into
microsoft:mainfrom
k-charansai:fix/19873-settings-tab-color

Conversation

@k-charansai

Copy link
Copy Markdown

Summary

This fixes the Settings tab color mismatch, addressing the visual inconsistency where the Settings tab appeared black while the Settings page was dark gray.

Looking at the history of the original fix (#19999) and its subsequent revert (#20292 / #20186), it appears the accessibility/contrast concern was isolated to the HighContrast theme change (SystemControlBackgroundBaseLowBrushSystemColorWindowBrush).

To address the original issue while avoiding the accessibility regression, this patch reapplies only the Dark and Light theme softening and leaves the HighContrast theme exactly as it is on main today.

Changes

  • Dark Theme: Aligned SettingsUiTabBrush from #0c0c0c to #282828 to match the Settings page background.
  • Light Theme: Aligned SettingsUiTabBrush from #ffffff to #F9F9F9.
  • HighContrast Theme: Left entirely unchanged.

Closes #19873

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting page UI enhancements

1 participant