[test-improver] Add unit tests for RetryAttemptPropertyExtensions.IsSupersededRetryAttempt

Goal and rationale

RetryAttemptPropertyExtensions.IsSupersededRetryAttempt(this TestNode) (src/Platform/Microsoft.Testing.Platform/Messages/RetryAttemptPropertyExtensions.cs) decides whether a TestNodeUpdateMessage is a non-final, superseded attempt of an in-process retry sequence (e.g. MSTest's [Retry]). It is consumed directly by 11+ report/consumer types across the platform and extensions (AzureDevOpsReporter, AzureDevOpsArtifactUploader, MSBuildConsumer, JUnitReportGenerator, RetryDataConsumer, HangDumpActivityIndicator, AbortForMaxFailedTestsExtension, SimplifiedConsoleOutputDeviceBase, TestApplicationResult, TrxDataConsumer, SlowTestReporterBase, VideoRecorderSessionHandler, GitHubActionsAnnotationReporter) to decide whether to count/report a retry attempt as the test's real outcome. Despite this breadth of consumers, it had zero direct unit tests — only incidental exercise through a handful of those consumers' own test suites.

Approach

Added RetryAttemptPropertyExtensionsTests.cs with 4 focused tests covering:

No RetryAttemptProperty present → false.
RetryAttemptProperty with IsSuperseded: true → true.
RetryAttemptProperty with IsSuperseded: false (the final attempt) → false.
Unrelated property present (no RetryAttemptProperty) → false.

Coverage impact

	net8.0	net9.0
Before	2866 total	2866 total
After	2870 total (+4)	2871 total (+5, includes one extra platform-gated test)
Failed	0	0
Skipped	22 (pre-existing)	22 (pre-existing)

Trade-offs

Minimal — 4 small, independent tests against a pure, side-effect-free extension method; no new test infrastructure or mocking needed.

Reproducibility

./build.sh -restore
export PATH="$PWD/.dotnet:$PATH"
dotnet build test/UnitTests/Microsoft.Testing.Platform.UnitTests/Microsoft.Testing.Platform.UnitTests.csproj -c Debug -f net8.0
./artifacts/bin/Microsoft.Testing.Platform.UnitTests/Debug/net8.0/Microsoft.Testing.Platform.UnitTests

Test Status

Build succeeded (0 warnings) for net8.0 and net9.0. Full Microsoft.Testing.Platform.UnitTests suite: 0 failed on both TFMs, no regressions. dotnet format whitespace --verify-no-changes clean (F#-project warning is expected/harmless, per repo convention).

Effectiveness evidence

Behavior and inputs	Independent expectation and source	Wrong implementation and distinguishing assertion	Real path and boundary/locale coverage	Evidence
`TestNode.IsSupersededRetryAttempt()` with a `RetryAttemptProperty(attemptNumber: 2, isSuperseded: false)` (the final, non-superseded attempt)	Per the XML-doc contract on `RetryAttemptProperty`/`RetryAttemptPropertyExtensions`: a present-but-not-superseded property means this is the test's final outcome, so the method must return `false`	Faulty implementation `=> testNode.Properties.SingleOrDefault<RetryAttemptProperty>() is not null;` (checks mere presence instead of `IsSuperseded`) incorrectly returns `true`; the `IsSupersededRetryAttempt_WhenRetryAttemptPropertyIsNotSuperseded_ReturnsFalse` assertion (`Assert.IsFalse(...)`) rejects it	Exercises the real `PropertyBag.SingleOrDefault<T>()` linked-list walk via a real `TestNode`/`PropertyBag`, matching how production consumers (e.g. `AzureDevOpsReporter`, `TrxDataConsumer`) call the same extension method on live `TestNodeUpdateMessage.TestNode` instances. Also covers "no property at all" and "unrelated property present" to catch a type-check bypass.	Executed red/green: injected the fault above into `RetryAttemptPropertyExtensions.cs`, rebuilt, reran the full suite — 5 tests failed (including the new distinguishing test) vs. 0 before/after; reverted the fault, rebuilt, reran — 0 failed, matching the original green baseline (2870/net8.0, 2871/net9.0).

Commands: dotnet build ... -f net8.0 (clean), then full-suite run via the built binary (no args) both before and after the temporary fault injection, as described above.

Note

This was originally intended as a pull request, but the git push operation failed.

Original error: The process '/usr/bin/git' failed with exit code 128

Workflow Run: View run details and download bundle artifact

The bundle file is available in the agent artifact in the workflow run linked above.

Create the pull request manually

# Download the artifact from the workflow run
gh run download '38001888846' -n agent -D '/tmp/agent-38001888846'

# Resolve the bundle source ref, fetch it into a temporary ref, then create the local branch
bundle_path='/tmp/agent-38001888846/aw-test-assist-retry-attempt-property-extensions-tests.bundle'
temp_ref='refs/bundles/create-pr-test-assist-retry-attempt-property-extensions-tests-11c33f6c015ddf16-1be5df90'
target_ref='refs/heads/test-assist/retry-attempt-property-extensions-tests-11c33f6c015ddf16'
bundle_source_ref=$(git bundle list-heads "$bundle_path" | awk '$2 ~ /^refs\/heads\// { print $2 }')
if [ -z "$bundle_source_ref" ]; then
  bundle_source_ref=$(git bundle list-heads "$bundle_path" | awk '$2 == "HEAD" { print $2 }')
fi
if [ "$(printf '%s\n' "$bundle_source_ref" | sed '/^$/d' | wc -l | tr -d ' ')" != "1" ]; then
  echo "Expected exactly one bundle source ref, found: $bundle_source_ref" >&2
  exit 1
fi
git fetch "$bundle_path" "${bundle_source_ref}:${temp_ref}"
git update-ref "$target_ref" "$temp_ref"
git checkout 'test-assist/retry-attempt-property-extensions-tests-11c33f6c015ddf16'
# Ensure the working tree matches the updated branch
git reset --hard
# Remove the temporary bundle ref
git update-ref -d "$temp_ref"

# Push the branch to the target remote
git push 'origin' 'test-assist/retry-attempt-property-extensions-tests-11c33f6c015ddf16'

# Create the pull request
gh pr create --title '[test-improver] Add unit tests for RetryAttemptPropertyExtensions.IsSupersededRetryAttempt' --base 'main' --head 'test-assist/retry-attempt-property-extensions-tests-11c33f6c015ddf16' --repo 'microsoft/testfx'

Warning

Firewall blocked 93 domains

The following domains were blocked by the firewall during workflow execution:

0t3vsblobprodcus362.vsblob.vsassets.io
11vvsblobprodcus336.vsblob.vsassets.io
1javsblobprodcus364.vsblob.vsassets.io
1k9vsblobprodcus379.vsblob.vsassets.io
1oavsblobprodcus350.vsblob.vsassets.io
1p7vsblobprodcus324.vsblob.vsassets.io
1s1vsblobprodcus386.vsblob.vsassets.io
2kmvsblobprodcus39.vsblob.vsassets.io
2zrvsblobprodcus388.vsblob.vsassets.io
37bvsblobprodcus311.vsblob.vsassets.io
37cvsblobprodcus359.vsblob.vsassets.io
4m6vsblobprodcus384.vsblob.vsassets.io
4myvsblobprodcus32.vsblob.vsassets.io
4vyvsblobprodcus361.vsblob.vsassets.io
4zjvsblobprodcus390.vsblob.vsassets.io
51yvsblobprodcus36.vsblob.vsassets.io
5dkvsblobprodcus355.vsblob.vsassets.io
5rqvsblobprodcus385.vsblob.vsassets.io
6s7vsblobprodcus313.vsblob.vsassets.io
7devsblobprodcus323.vsblob.vsassets.io
7k6vsblobprodcus337.vsblob.vsassets.io
7tjvsblobprodcus341.vsblob.vsassets.io
80zvsblobprodcus35.vsblob.vsassets.io
8xbvsblobprodcus382.vsblob.vsassets.io
96bvsblobprodcus338.vsblob.vsassets.io
ajhvsblobprodcus363.vsblob.vsassets.io
bcnvsblobprodcus378.vsblob.vsassets.io
builds.dotnet.microsoft.com
c50vsblobprodcus330.vsblob.vsassets.io
c78vsblobprodcus322.vsblob.vsassets.io
cflvsblobprodcus383.vsblob.vsassets.io
ci.dot.net
ckzvsblobprodcus347.vsblob.vsassets.io
d0svsblobprodcus381.vsblob.vsassets.io
data.nuget.org
dlbvsblobprodcus316.vsblob.vsassets.io
e7bvsblobprodcus348.vsblob.vsassets.io
fdpvsblobprodcus345.vsblob.vsassets.io
frdvsblobprodcus327.vsblob.vsassets.io
gbsvsblobprodcus365.vsblob.vsassets.io
gervsblobprodcus329.vsblob.vsassets.io
h6tvsblobprodcus346.vsblob.vsassets.io
i1qvsblobprodcus353.vsblob.vsassets.io
ibzvsblobprodcus369.vsblob.vsassets.io
imzvsblobprodcus368.vsblob.vsassets.io
jd4vsblobprodcus366.vsblob.vsassets.io
josvsblobprodcus372.vsblob.vsassets.io
jrqvsblobprodcus343.vsblob.vsassets.io
k0ivsblobprodcus356.vsblob.vsassets.io
k4kvsblobprodcus344.vsblob.vsassets.io
kgfvsblobprodcus314.vsblob.vsassets.io
kh4vsblobprodcus325.vsblob.vsassets.io
kijvsblobprodcus387.vsblob.vsassets.io
kmuvsblobprodcus389.vsblob.vsassets.io
kxqvsblobprodcus376.vsblob.vsassets.io
l49vsblobprodcus358.vsblob.vsassets.io
l7avsblobprodcus319.vsblob.vsassets.io
ljcvsblobprodcus317.vsblob.vsassets.io
lylvsblobprodcus31.vsblob.vsassets.io
m16vsblobprodcus374.vsblob.vsassets.io
m6xvsblobprodcus342.vsblob.vsassets.io
m8dvsblobprodcus37.vsblob.vsassets.io
mfjvsblobprodcus373.vsblob.vsassets.io
n3kvsblobprodcus335.vsblob.vsassets.io
nn8vsblobprodcus340.vsblob.vsassets.io
o3svsblobprodcus318.vsblob.vsassets.io
ofvvsblobprodcus315.vsblob.vsassets.io
p2ovsblobprodcus312.vsblob.vsassets.io
pc2vsblobprodcus360.vsblob.vsassets.io
pdfvsblobprodcus380.vsblob.vsassets.io
pe3vsblobprodcus354.vsblob.vsassets.io
pe4vsblobprodcus351.vsblob.vsassets.io
pkgs.dev.azure.com
pkvvsblobprodcus321.vsblob.vsassets.io
rcxvsblobprodcus328.vsblob.vsassets.io
s4uvsblobprodcus326.vsblob.vsassets.io
s8mvsblobprodcus38.vsblob.vsassets.io
se1vsblobprodcus349.vsblob.vsassets.io
sqdvsblobprodcus333.vsblob.vsassets.io
st8vsblobprodcus339.vsblob.vsassets.io
tphvsblobprodcus375.vsblob.vsassets.io
u3hvsblobprodcus371.vsblob.vsassets.io
u6ovsblobprodcus377.vsblob.vsassets.io
ukkvsblobprodcus352.vsblob.vsassets.io
uy6vsblobprodcus34.vsblob.vsassets.io
v53vsblobprodcus320.vsblob.vsassets.io
vb4vsblobprodcus33.vsblob.vsassets.io
vwvvsblobprodcus334.vsblob.vsassets.io
x3yvsblobprodcus370.vsblob.vsassets.io
xupvsblobprodcus332.vsblob.vsassets.io
yluvsblobprodcus367.vsblob.vsassets.io
yttvsblobprodcus357.vsblob.vsassets.io
ytvvsblobprodcus310.vsblob.vsassets.io

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "0t3vsblobprodcus362.vsblob.vsassets.io"
    - "11vvsblobprodcus336.vsblob.vsassets.io"
    - "1javsblobprodcus364.vsblob.vsassets.io"
    - "1k9vsblobprodcus379.vsblob.vsassets.io"
    - "1oavsblobprodcus350.vsblob.vsassets.io"
    - "1p7vsblobprodcus324.vsblob.vsassets.io"
    - "1s1vsblobprodcus386.vsblob.vsassets.io"
    - "2kmvsblobprodcus39.vsblob.vsassets.io"
    - "2zrvsblobprodcus388.vsblob.vsassets.io"
    - "37bvsblobprodcus311.vsblob.vsassets.io"
    - "37cvsblobprodcus359.vsblob.vsassets.io"
    - "4m6vsblobprodcus384.vsblob.vsassets.io"
    - "4myvsblobprodcus32.vsblob.vsassets.io"
    - "4vyvsblobprodcus361.vsblob.vsassets.io"
    - "4zjvsblobprodcus390.vsblob.vsassets.io"
    - "51yvsblobprodcus36.vsblob.vsassets.io"
    - "5dkvsblobprodcus355.vsblob.vsassets.io"
    - "5rqvsblobprodcus385.vsblob.vsassets.io"
    - "6s7vsblobprodcus313.vsblob.vsassets.io"
    - "7devsblobprodcus323.vsblob.vsassets.io"
    - "7k6vsblobprodcus337.vsblob.vsassets.io"
    - "7tjvsblobprodcus341.vsblob.vsassets.io"
    - "80zvsblobprodcus35.vsblob.vsassets.io"
    - "8xbvsblobprodcus382.vsblob.vsassets.io"
    - "96bvsblobprodcus338.vsblob.vsassets.io"
    - "ajhvsblobprodcus363.vsblob.vsassets.io"
    - "bcnvsblobprodcus378.vsblob.vsassets.io"
    - "builds.dotnet.microsoft.com"
    - "c50vsblobprodcus330.vsblob.vsassets.io"
    - "c78vsblobprodcus322.vsblob.vsassets.io"
    - "cflvsblobprodcus383.vsblob.vsassets.io"
    - "ci.dot.net"
    - "ckzvsblobprodcus347.vsblob.vsassets.io"
    - "d0svsblobprodcus381.vsblob.vsassets.io"
    - "data.nuget.org"
    - "dlbvsblobprodcus316.vsblob.vsassets.io"
    - "e7bvsblobprodcus348.vsblob.vsassets.io"
    - "fdpvsblobprodcus345.vsblob.vsassets.io"
    - "frdvsblobprodcus327.vsblob.vsassets.io"
    - "gbsvsblobprodcus365.vsblob.vsassets.io"
    - "gervsblobprodcus329.vsblob.vsassets.io"
    - "h6tvsblobprodcus346.vsblob.vsassets.io"
    - "i1qvsblobprodcus353.vsblob.vsassets.io"
    - "ibzvsblobprodcus369.vsblob.vsassets.io"
    - "imzvsblobprodcus368.vsblob.vsassets.io"
    - "jd4vsblobprodcus366.vsblob.vsassets.io"
    - "josvsblobprodcus372.vsblob.vsassets.io"
    - "jrqvsblobprodcus343.vsblob.vsassets.io"
    - "k0ivsblobprodcus356.vsblob.vsassets.io"
    - "k4kvsblobprodcus344.vsblob.vsassets.io"
    - "kgfvsblobprodcus314.vsblob.vsassets.io"
    - "kh4vsblobprodcus325.vsblob.vsassets.io"
    - "kijvsblobprodcus387.vsblob.vsassets.io"
    - "kmuvsblobprodcus389.vsblob.vsassets.io"
    - "kxqvsblobprodcus376.vsblob.vsassets.io"
    - "l49vsblobprodcus358.vsblob.vsassets.io"
    - "l7avsblobprodcus319.vsblob.vsassets.io"
    - "ljcvsblobprodcus317.vsblob.vsassets.io"
    - "lylvsblobprodcus31.vsblob.vsassets.io"
    - "m16vsblobprodcus374.vsblob.vsassets.io"
    - "m6xvsblobprodcus342.vsblob.vsassets.io"
    - "m8dvsblobprodcus37.vsblob.vsassets.io"
    - "mfjvsblobprodcus373.vsblob.vsassets.io"
    - "n3kvsblobprodcus335.vsblob.vsassets.io"
    - "nn8vsblobprodcus340.vsblob.vsassets.io"
    - "o3svsblobprodcus318.vsblob.vsassets.io"
    - "ofvvsblobprodcus315.vsblob.vsassets.io"
    - "p2ovsblobprodcus312.vsblob.vsassets.io"
    - "pc2vsblobprodcus360.vsblob.vsassets.io"
    - "pdfvsblobprodcus380.vsblob.vsassets.io"
    - "pe3vsblobprodcus354.vsblob.vsassets.io"
    - "pe4vsblobprodcus351.vsblob.vsassets.io"
    - "pkgs.dev.azure.com"
    - "pkvvsblobprodcus321.vsblob.vsassets.io"
    - "rcxvsblobprodcus328.vsblob.vsassets.io"
    - "s4uvsblobprodcus326.vsblob.vsassets.io"
    - "s8mvsblobprodcus38.vsblob.vsassets.io"
    - "se1vsblobprodcus349.vsblob.vsassets.io"
    - "sqdvsblobprodcus333.vsblob.vsassets.io"
    - "st8vsblobprodcus339.vsblob.vsassets.io"
    - "tphvsblobprodcus375.vsblob.vsassets.io"
    - "u3hvsblobprodcus371.vsblob.vsassets.io"
    - "u6ovsblobprodcus377.vsblob.vsassets.io"
    - "ukkvsblobprodcus352.vsblob.vsassets.io"
    - "uy6vsblobprodcus34.vsblob.vsassets.io"
    - "v53vsblobprodcus320.vsblob.vsassets.io"
    - "vb4vsblobprodcus33.vsblob.vsassets.io"
    - "vwvvsblobprodcus334.vsblob.vsassets.io"
    - "x3yvsblobprodcus370.vsblob.vsassets.io"
    - "xupvsblobprodcus332.vsblob.vsassets.io"
    - "yluvsblobprodcus367.vsblob.vsassets.io"
    - "yttvsblobprodcus357.vsblob.vsassets.io"
    - "ytvvsblobprodcus310.vsblob.vsassets.io"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Test Improver workflow. · copilot · auto · 267.6 AIC · ⌖ 16.4 AIC · ⊞ 22.1K · [◷]( · ◷)
_{Comment /test-assist to run again}

_{Add this agentic workflow to your repo}

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/test-improver.md@main

Navigation Menu

Repository navigation

[test-improver] Add unit tests for RetryAttemptPropertyExtensions.IsSupersededRetryAttempt #11869

Goal and rationale

Approach

Coverage impact

Trade-offs

Reproducibility

Test Status

Effectiveness evidence

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[test-improver] Add unit tests for RetryAttemptPropertyExtensions.IsSupersededRetryAttempt #11869

Description

Goal and rationale

Approach

Coverage impact

Trade-offs

Reproducibility

Test Status

Effectiveness evidence

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions