packaging: rename trident-acl-agent subpackage to trident-acl

[bfjelds (bfjelds)]

Renames the RPM subpackage from trident-acl-agent to trident-acl in packaging/rpm/trident.spec. The underlying binary, systemd unit, and cargo crate names are unchanged; only the subpackage name/tags (%package, %description, %files, %post, %preun, %postun) are updated.

[azure-pipelines]

Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

Pull request overview

This PR updates the RPM spec to rename the RPM subpackage from trident-acl-agent to trident-acl, while keeping the underlying binary (trident-acl-agent) and systemd unit unchanged.

Changes:

• Renamed the RPM subpackage tags from acl-agent to acl (%package, %description, %files, %post, %preun, %postun).

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

packaging/rpm/trident.spec:232

• Renaming an RPM subpackage usually needs compatibility tags so upgrades from the old name work (and so dependencies on the old subpackage name don’t break). With only %package renamed, tdnf upgrade from trident-acl-agent may leave the old package installed or fail to pull in trident-acl.

Add Provides:/Obsoletes: for the previous subpackage name in the new %package acl section.

%package acl
Summary:        Trident ACL Components
Requires:       %{name} = %{version}-%{release}

[bfjelds (bfjelds)]

/azp run [GITHUB]-trident-pr-e2e

[azure-pipelines]

Azure Pipelines:
Successfully started running 1 pipeline(s).

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

scripts/extract-binary.sh:58

• The extracted RPM is now trident-acl-*, but the script still copies it to a temp filename trident-acl-agent.rpm and runs rpm2cpio trident-acl-agent.rpm. This works, but the filename no longer matches the package being extracted, which makes the set -x logs and future maintenance confusing after the rename.

Rename the temp RPM filename (and rpm2cpio argument) to trident-acl.rpm, and update the comment to reference the trident-acl subpackage explicitly.

# Extract trident-acl-agent binary from the acl sub-package RPM
ACL_AGENT_RPM=$(find "$RPM_DIR" | grep -P "trident-acl-\d.*\.${DISTRO}\.${RPM_ARCH}\.rpm" | head -n 1 || true)
if [ -n "$ACL_AGENT_RPM" ]; then
  ACL_TMP_DIR=$(mktemp -d)
  cp "$ACL_AGENT_RPM" "$ACL_TMP_DIR/trident-acl-agent.rpm"