Skip to content

acl: surface Trident error (kind/subkind/location) on the update-stated annotation #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bfjelds (bfjelds) merged 5 commits into from
Sep 1, 2026
+275 −11
Merged

acl: surface Trident error (kind/subkind/location) on the update-stated annotation #761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1e79c93
acl: surface Trident error (kind/subkind/location) on the update-stat…
bfjelds Aug 31, 2026
5a562ae
docs: document tridentError in the update-status annotation
bfjelds Sep 1, 2026
300d7ce
acl-agent: constrain error location line to u32 range in formal schema
bfjelds Sep 1, 2026
0952ce9
docs: correct tridentError scope in update-status contract
bfjelds Sep 1, 2026
ad1da74
acl-agent: reject fractional values for schema integer properties
bfjelds Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions crates/trident-acl-agent/src/annotations/orchestrator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@ impl Orchestrator {
operation: invalid.operation,
code: StatusCode::InvalidRequest,
message: invalid.reason,
trident_error: None,
from_version: None,
to_version: None,
started_utc: now,
Expand Down Expand Up @@ -1535,7 +1536,8 @@ fn stage_result_to_status(
to_version,
started,
Some(Utc::now()),
),
)
.with_trident_error(&err),
}
}

Expand Down Expand Up @@ -1583,6 +1585,7 @@ fn finalize_failure_status(
started,
Some(Utc::now()),
)
.with_trident_error(err)
}

/// Maps a `commit()` (or `update_finalize()`/`rollback_finalize()` sharing
Expand Down Expand Up @@ -1730,7 +1733,8 @@ fn reconstruct_commit_result_to_status(
request.target_version.clone(),
started,
Some(Utc::now()),
),
)
.with_trident_error(&err),
Err(err) => UpdateStatus::new(
request,
Operation::Commit,
Expand All @@ -1741,7 +1745,8 @@ fn reconstruct_commit_result_to_status(
request.target_version.clone(),
started,
Some(Utc::now()),
),
)
.with_trident_error(&err),
}
}

Expand Down Expand Up @@ -1808,7 +1813,8 @@ fn commit_result_to_status(
pending.to_version.clone(),
pending.started_utc,
Some(Utc::now()),
),
)
.with_trident_error(&err),
Err(err) => UpdateStatus::new(
&pending.request,
Operation::Commit,
Expand All @@ -1819,7 +1825,8 @@ fn commit_result_to_status(
pending.to_version.clone(),
pending.started_utc,
Some(Utc::now()),
),
)
.with_trident_error(&err),
}
}

Expand All @@ -1844,6 +1851,7 @@ fn rollback_stage_failure_status(
started,
Some(Utc::now()),
)
.with_trident_error(err)
}

/// Builds the terminal `UpdateStatus` for a successful rollback_finalize()
Expand Down Expand Up @@ -1887,6 +1895,7 @@ fn rollback_finalize_failure_status(
started,
Some(Utc::now()),
)
.with_trident_error(err)
}

#[cfg(test)]
Expand Down
Loading
Loading