Warn on TSServer Plugin Contributions from other extensions#4063
Open
DanielRosenwasser wants to merge 11 commits into
Open
Warn on TSServer Plugin Contributions from other extensions#4063DanielRosenwasser wants to merge 11 commits into
DanielRosenwasser wants to merge 11 commits into
Conversation
…js/ts over typescript.
…dence and resolution
DanielRosenwasser
changed the title
| const settingName = getWinningTsgoConfigKey()!; | ||
| assert(settingName !== undefined, "Expected some useTsgo configuration to be explicitly set."); | ||
|
|
||
| const target = getExplicitConfigTarget(vscode.workspace.getConfiguration(), settingName); |
Comment on lines
+130
to
+132
| warnAboutTsServerPlugins(context, output); | ||
| context.subscriptions.push(vscode.extensions.onDidChange(() => { | ||
| warnAboutTsServerPlugins(context, output); |
Comment on lines
+220
to
+230
| const ok = "OK"; | ||
| const disableInWorkspace = "Disable in Workspace"; | ||
| const dontShowAgain = hasWorkspaceFolder ? "Don't Show Again in Workspace" : "Don't Show Again"; | ||
|
|
||
| const options = [ok]; | ||
| if (hasWorkspaceFolder) { | ||
| options.push(disableInWorkspace); | ||
| } | ||
| options.push(dontShowAgain); | ||
|
|
||
| const selected = await vscode.window.showWarningMessage(message, ...options); |
Member
Author
There was a problem hiding this comment.
Maybe we should just have some state so we don't show it more than once per session.
DanielRosenwasser
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Builds on #4052)
Fixes #3848.