Fix JS bind expando declaration emit#4069
Open
cjc0013 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4045
This updates declaration emit for JS variables initialized from
fn.bind({})so the exported alias is emitted as a function declaration based on the bound target signature instead ofconst alias: typeof fn. That avoids leaking non-exported implementation functions into the generated.d.ts.It also carries expando properties from the bound source function onto the public alias, while letting alias-owned expando assignments provide their own property declarations.
Tests:
go build -tags=noembed -o .\built\local\tsgo.exe .\cmd\tsgogo test ./internal/testrunner/ -run 'TestLocal/(declarationEmitExpandoFunction|declarationEmitExpandoArrowFunctionParameter|functionExpandoPropertyDeclaration|jsExpandoAssignmentElementAccess|declarationEmitJsBindExpandoFunction)' -vgo test ./internal/transformers/declarationsgit diff --checkAI disclosure: I used Codex to help investigate and draft this change; I reviewed the diff and test output and will respond to feedback myself.