Fix fantasticon usage on Windows, add Windows PR check#457
Merged
Conversation
alexdima
changed the title
bpasero
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See tancredi/fantasticon#470 . fantasticon has a long standing problem on Windows with the way they pass in strings containing
\toglob, which leads to them not finding any svg files. This causes an error and this breaks our build, specifically theAPIScanstep, which runs on Windows.This PR:
globto pass in strings containing/instead of\. Not ideal, but the best we can do until the problem is resolved upstream.