tests: Fix external URI opener cherry-pick - #8963
Merged
Benjamin Christopher Simmonds (benibenj) merged 1 commit intoSep 16, 2026
Merged
Benjamin Christopher Simmonds (benibenj) merged 1 commit into
Benjamin Christopher Simmonds (benibenj) merged 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Benjamin Christopher Simmonds (benibenj)
September 16, 2026 13:07
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review tier: Lite
Findings: None
What changed in this PR
Updates external URI opener tests to avoid mutating global VS Code configuration after cherry-picking changes.
Changes:
- Stub opener settings directly.
- Remove obsolete configuration handling and invalid cleanup references.
| File | Description |
|---|---|
src/test/github/externalUriOpener.test.ts |
Isolates opener-setting behavior and cleans up test logic. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Benjamin Christopher Simmonds (benibenj)
enabled auto-merge (squash)
September 16, 2026 13:10
Alexandru Dima (alexdima)
approved these changes
Sep 16, 2026
Benjamin Christopher Simmonds (benibenj)
merged commit Sep 16, 2026
c4bcb20
into
release/1.166
7 checks passed
Benjamin Christopher Simmonds (benibenj)
deleted the
benibenj/release-1.166-compile-fix
branch
September 16, 2026 13:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release/1.166Validation
npm run compilenpm run lintnpm run hygienenpm test(affected external URI opener tests pass; suite has 16 unrelated Windows line-ending failures in Real Diff Apply)